diff options
author | Anders Carlsson <andersca@mac.com> | 2010-10-06 02:43:25 +0000 |
---|---|---|
committer | Anders Carlsson <andersca@mac.com> | 2010-10-06 02:43:25 +0000 |
commit | 0f7e94fd7b7d877359cfeeb9d9d9ca52f2577233 (patch) | |
tree | 1a661675540091143eda6e4421e9ee30efce9841 | |
parent | ad205575fcaaf17f00fdde3cda58eb6db1542fa4 (diff) | |
download | bcm5719-llvm-0f7e94fd7b7d877359cfeeb9d9d9ca52f2577233.tar.gz bcm5719-llvm-0f7e94fd7b7d877359cfeeb9d9d9ca52f2577233.zip |
When checking for uninitialized fields in member initializers, special case static variables and enums. Fixes PR8075.
llvm-svn: 115732
-rw-r--r-- | clang/lib/Sema/SemaDeclCXX.cpp | 13 | ||||
-rw-r--r-- | clang/test/SemaCXX/constructor-initializer.cpp | 29 |
2 files changed, 42 insertions, 0 deletions
diff --git a/clang/lib/Sema/SemaDeclCXX.cpp b/clang/lib/Sema/SemaDeclCXX.cpp index 1e4065454ed..cbb16fe17ed 100644 --- a/clang/lib/Sema/SemaDeclCXX.cpp +++ b/clang/lib/Sema/SemaDeclCXX.cpp @@ -1163,6 +1163,19 @@ static bool InitExprContainsUninitializedFields(const Stmt *S, } if (const MemberExpr *ME = dyn_cast<MemberExpr>(S)) { const NamedDecl *RhsField = ME->getMemberDecl(); + + if (const VarDecl *VD = dyn_cast<VarDecl>(RhsField)) { + // The member expression points to a static data member. + assert(VD->isStaticDataMember() && + "Member points to non-static data member!"); + return false; + } + + if (isa<EnumConstantDecl>(RhsField)) { + // The member expression points to an enum. + return false; + } + if (RhsField == LhsField) { // Initializing a field with itself. Throw a warning. // But wait; there are exceptions! diff --git a/clang/test/SemaCXX/constructor-initializer.cpp b/clang/test/SemaCXX/constructor-initializer.cpp index a74fbe1800e..e439a76c17c 100644 --- a/clang/test/SemaCXX/constructor-initializer.cpp +++ b/clang/test/SemaCXX/constructor-initializer.cpp @@ -239,3 +239,32 @@ namespace test3 { } }; } + +// PR8075 +namespace PR8075 { + +struct S1 { + enum { FOO = 42 }; + static const int bar = 42; + static int baz(); + S1(int); +}; + +const int S1::bar; + +struct S2 { + S1 s1; + S2() : s1(s1.FOO) {} +}; + +struct S3 { + S1 s1; + S3() : s1(s1.bar) {} +}; + +struct S4 { + S1 s1; + S4() : s1(s1.baz()) {} +}; + +} |