diff options
author | Davide Italiano <davide@freebsd.org> | 2019-06-20 23:44:37 +0000 |
---|---|---|
committer | Davide Italiano <davide@freebsd.org> | 2019-06-20 23:44:37 +0000 |
commit | 0cdae2681a28e40ef0b80a024ae145a493448f40 (patch) | |
tree | 4e9fb50b0149a1da8a86e5b8ee11287637c17e45 | |
parent | 1c0bd6dd2ca71f4ad8d4984340a729b3e959cb80 (diff) | |
download | bcm5719-llvm-0cdae2681a28e40ef0b80a024ae145a493448f40.tar.gz bcm5719-llvm-0cdae2681a28e40ef0b80a024ae145a493448f40.zip |
Revert "Fix a crash in option parsing."
This fails on the bots around 1/10 of the time.
llvm-svn: 363999
-rw-r--r-- | lldb/lit/Driver/Inputs/process_attach_pid.in | 1 | ||||
-rw-r--r-- | lldb/lit/Driver/TestProcessAttach.test | 2 | ||||
-rw-r--r-- | lldb/source/Interpreter/Options.cpp | 6 |
3 files changed, 0 insertions, 9 deletions
diff --git a/lldb/lit/Driver/Inputs/process_attach_pid.in b/lldb/lit/Driver/Inputs/process_attach_pid.in deleted file mode 100644 index 010f607b835..00000000000 --- a/lldb/lit/Driver/Inputs/process_attach_pid.in +++ /dev/null @@ -1 +0,0 @@ -process attach --pid diff --git a/lldb/lit/Driver/TestProcessAttach.test b/lldb/lit/Driver/TestProcessAttach.test deleted file mode 100644 index e042df0370c..00000000000 --- a/lldb/lit/Driver/TestProcessAttach.test +++ /dev/null @@ -1,2 +0,0 @@ -# RUN: %lldb -x -b -S %S/Inputs/process_attach_pid.in 2>&1 | FileCheck %s -# CHECK: requires an argument diff --git a/lldb/source/Interpreter/Options.cpp b/lldb/source/Interpreter/Options.cpp index 80e88829c00..814998ec68f 100644 --- a/lldb/source/Interpreter/Options.cpp +++ b/lldb/source/Interpreter/Options.cpp @@ -1362,12 +1362,6 @@ llvm::Expected<Args> Options::Parse(const Args &args, int long_options_index = -1; val = OptionParser::Parse(argv.size(), &*argv.begin(), sstr.GetString(), long_options, &long_options_index); - - if ((size_t)OptionParser::GetOptionIndex() > argv.size()) { - error.SetErrorStringWithFormat("option requires an argument"); - break; - } - if (val == -1) break; |