diff options
| author | Zinovy Nis <zinovy.nis@gmail.com> | 2016-03-22 13:50:57 +0000 |
|---|---|---|
| committer | Zinovy Nis <zinovy.nis@gmail.com> | 2016-03-22 13:50:57 +0000 |
| commit | 07ac2bd4d0ed3dfd9b93e49ba302f7197bc0cd6d (patch) | |
| tree | 8290dd9313e0aa60df99acfc22d15dae05379f8d | |
| parent | 4c9c07414ea6a6cc76f3303baeabf737dcb6e267 (diff) | |
| download | bcm5719-llvm-07ac2bd4d0ed3dfd9b93e49ba302f7197bc0cd6d.tar.gz bcm5719-llvm-07ac2bd4d0ed3dfd9b93e49ba302f7197bc0cd6d.zip | |
[PATCH] Force LoopReroll to reset the loop trip count value after reroll.
It's a bug fix.
For rerolled loops SE trip count remains unchanged. It leads to incorrect work of the next passes.
My patch just resets SE info for rerolled loop forcing SE to re-evaluate it next time it requested.
I also added a verifier call in the exisitng test to be sure no invalid SE data remain. Without my fix this test would fail with -verify-scev.
Differential Revision: http://reviews.llvm.org/D18316
llvm-svn: 264051
| -rw-r--r-- | llvm/lib/Transforms/Scalar/LoopRerollPass.cpp | 13 | ||||
| -rw-r--r-- | llvm/test/Transforms/LoopReroll/basic32iters.ll | 2 |
2 files changed, 9 insertions, 6 deletions
diff --git a/llvm/lib/Transforms/Scalar/LoopRerollPass.cpp b/llvm/lib/Transforms/Scalar/LoopRerollPass.cpp index fae80d90ea7..3fb0a104c3f 100644 --- a/llvm/lib/Transforms/Scalar/LoopRerollPass.cpp +++ b/llvm/lib/Transforms/Scalar/LoopRerollPass.cpp @@ -1551,14 +1551,12 @@ bool LoopReroll::runOnLoop(Loop *L, LPPassManager &LPM) { "] Loop %" << Header->getName() << " (" << L->getNumBlocks() << " block(s))\n"); - bool Changed = false; - // For now, we'll handle only single BB loops. if (L->getNumBlocks() > 1) - return Changed; + return false; if (!SE->hasLoopInvariantBackedgeTakenCount(L)) - return Changed; + return false; const SCEV *LIBETC = SE->getBackedgeTakenCount(L); const SCEV *IterCount = SE->getAddExpr(LIBETC, SE->getOne(LIBETC->getType())); @@ -1572,11 +1570,12 @@ bool LoopReroll::runOnLoop(Loop *L, LPPassManager &LPM) { if (PossibleIVs.empty()) { DEBUG(dbgs() << "LRR: No possible IVs found\n"); - return Changed; + return false; } ReductionTracker Reductions; collectPossibleReductions(L, Reductions); + bool Changed = false; // For each possible IV, collect the associated possible set of 'root' nodes // (i+1, i+2, etc.). @@ -1587,5 +1586,9 @@ bool LoopReroll::runOnLoop(Loop *L, LPPassManager &LPM) { break; } + // Trip count of L has changed so SE must be re-evaluated. + if (Changed) + SE->forgetLoop(L); + return Changed; } diff --git a/llvm/test/Transforms/LoopReroll/basic32iters.ll b/llvm/test/Transforms/LoopReroll/basic32iters.ll index d39b0e6a915..758fd8a0a79 100644 --- a/llvm/test/Transforms/LoopReroll/basic32iters.ll +++ b/llvm/test/Transforms/LoopReroll/basic32iters.ll @@ -1,4 +1,4 @@ -; RUN: opt < %s -loop-reroll -S | FileCheck %s +; RUN: opt < %s -loop-reroll -verify-scev -S | FileCheck %s target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64-S128" target triple = "x86_64-unknown-linux-gnu" |
