diff options
| author | Davide Italiano <davide@freebsd.org> | 2015-10-24 22:15:32 +0000 |
|---|---|---|
| committer | Davide Italiano <davide@freebsd.org> | 2015-10-24 22:15:32 +0000 |
| commit | 05d980e48d8afb1d5d227e1d2e4f29d74567dae3 (patch) | |
| tree | fd7b627767af747d74ffa2072f7e2b55c5db7d1b | |
| parent | df1ec5561a4a28a98ae3435878967875d19dd85e (diff) | |
| download | bcm5719-llvm-05d980e48d8afb1d5d227e1d2e4f29d74567dae3.tar.gz bcm5719-llvm-05d980e48d8afb1d5d227e1d2e4f29d74567dae3.zip | |
[Support] Add comment to explain why we can't drop NDEBUG.
Discussed with: Benjamin Kramer.
llvm-svn: 251210
| -rw-r--r-- | llvm/include/llvm/Support/UnicodeCharRanges.h | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/llvm/include/llvm/Support/UnicodeCharRanges.h b/llvm/include/llvm/Support/UnicodeCharRanges.h index 9f738dff110..134698c3ec6 100644 --- a/llvm/include/llvm/Support/UnicodeCharRanges.h +++ b/llvm/include/llvm/Support/UnicodeCharRanges.h @@ -51,6 +51,11 @@ public: /// the constructor, so it makes sense to create as few UnicodeCharSet /// instances per each array of ranges, as possible. #ifdef NDEBUG + + // FIXME: This could use constexpr + static_assert. This way we + // may get rid of NDEBUG in this header. Unfortunately there are some + // problems to get this working with MSVC 2013. Change this when + // the support for MSVC 2013 is dropped. LLVM_CONSTEXPR UnicodeCharSet(CharRanges Ranges) : Ranges(Ranges) {} #else UnicodeCharSet(CharRanges Ranges) : Ranges(Ranges) { |
