summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJoerg Sonnenberger <joerg@bec.de>2013-11-19 13:38:38 +0000
committerJoerg Sonnenberger <joerg@bec.de>2013-11-19 13:38:38 +0000
commit05bd2da3280e78ce30465e15b04b4864ea137270 (patch)
treeece3564c1d500755757bb298795c03e613a6c253
parent9ff321d18db2a4f4f6895f71b9b90016546f27b8 (diff)
downloadbcm5719-llvm-05bd2da3280e78ce30465e15b04b4864ea137270.tar.gz
bcm5719-llvm-05bd2da3280e78ce30465e15b04b4864ea137270.zip
Revert r194540, it breaks various C++ programs.
llvm-svn: 195126
-rw-r--r--clang/lib/Sema/SemaExpr.cpp13
-rw-r--r--clang/test/Sema/warn-null.c6
2 files changed, 2 insertions, 17 deletions
diff --git a/clang/lib/Sema/SemaExpr.cpp b/clang/lib/Sema/SemaExpr.cpp
index 8ec58d4283d..22242a5acc9 100644
--- a/clang/lib/Sema/SemaExpr.cpp
+++ b/clang/lib/Sema/SemaExpr.cpp
@@ -10619,17 +10619,8 @@ bool Sema::DiagnoseAssignmentResult(AssignConvertType ConvTy,
switch (ConvTy) {
case Compatible:
- // See if a proper null pointer constant is to be assigned.
- if (DstType->isAnyPointerType() && !SrcType->isAnyPointerType() &&
- SrcExpr->isNullPointerConstant(Context,
- Expr::NPC_NeverValueDependent) ==
- Expr::NPCK_ZeroExpression &&
- !isUnevaluatedContext())
- Diag(SrcExpr->getExprLoc(), diag::warn_non_literal_null_pointer)
- << DstType << SrcExpr->getSourceRange();
-
- DiagnoseAssignmentEnum(DstType, SrcType, SrcExpr);
- return false;
+ DiagnoseAssignmentEnum(DstType, SrcType, SrcExpr);
+ return false;
case PointerToInt:
DiagKind = diag::ext_typecheck_convert_pointer_int;
diff --git a/clang/test/Sema/warn-null.c b/clang/test/Sema/warn-null.c
deleted file mode 100644
index 8ac8c5c9d34..00000000000
--- a/clang/test/Sema/warn-null.c
+++ /dev/null
@@ -1,6 +0,0 @@
-// RUN: %clang_cc1 %s -verify -fsyntax-only
-
-// PR10837: warn if a non-pointer-typed expression is folded to a null pointer
-int *p = 0;
-int *q = '\0'; // expected-warning{{expression which evaluates to zero treated as a null pointer constant}}
-int *r = (1 - 1); // expected-warning{{expression which evaluates to zero treated as a null pointer constant}}
OpenPOWER on IntegriCloud