diff options
| author | Benjamin Kramer <benny.kra@googlemail.com> | 2018-09-24 17:51:15 +0000 |
|---|---|---|
| committer | Benjamin Kramer <benny.kra@googlemail.com> | 2018-09-24 17:51:15 +0000 |
| commit | 0181e7a6bde60c9cfb1877b0bd1324e234544e5f (patch) | |
| tree | be7c8b1153253575f4c93a840de7a9157bd662dc | |
| parent | 51cbd838d04c7a8792031bd0a3d48d0c12b25816 (diff) | |
| download | bcm5719-llvm-0181e7a6bde60c9cfb1877b0bd1324e234544e5f.tar.gz bcm5719-llvm-0181e7a6bde60c9cfb1877b0bd1324e234544e5f.zip | |
Fix the type of 1<<31 integer constants.
Shifting into the sign bit is technically undefined behavior. No known
compiler exploits it though.
llvm-svn: 342909
| -rw-r--r-- | clang/include/clang/Basic/SourceManager.h | 4 | ||||
| -rw-r--r-- | clang/lib/CodeGen/CGBlocks.h | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/clang/include/clang/Basic/SourceManager.h b/clang/include/clang/Basic/SourceManager.h index af7dbbc13ca..c5a53960b36 100644 --- a/clang/include/clang/Basic/SourceManager.h +++ b/clang/include/clang/Basic/SourceManager.h @@ -449,7 +449,7 @@ namespace SrcMgr { } static SLocEntry get(unsigned Offset, const FileInfo &FI) { - assert(!(Offset & (1 << 31)) && "Offset is too large"); + assert(!(Offset & (1u << 31)) && "Offset is too large"); SLocEntry E; E.Offset = Offset; E.IsExpansion = false; @@ -458,7 +458,7 @@ namespace SrcMgr { } static SLocEntry get(unsigned Offset, const ExpansionInfo &Expansion) { - assert(!(Offset & (1 << 31)) && "Offset is too large"); + assert(!(Offset & (1u << 31)) && "Offset is too large"); SLocEntry E; E.Offset = Offset; E.IsExpansion = true; diff --git a/clang/lib/CodeGen/CGBlocks.h b/clang/lib/CodeGen/CGBlocks.h index c802948af06..3f9fc16d9b1 100644 --- a/clang/lib/CodeGen/CGBlocks.h +++ b/clang/lib/CodeGen/CGBlocks.h @@ -60,7 +60,7 @@ enum BlockLiteralFlags { BLOCK_IS_GLOBAL = (1 << 28), BLOCK_USE_STRET = (1 << 29), BLOCK_HAS_SIGNATURE = (1 << 30), - BLOCK_HAS_EXTENDED_LAYOUT = (1 << 31) + BLOCK_HAS_EXTENDED_LAYOUT = (1u << 31) }; class BlockFlags { uint32_t flags; |

