diff options
author | Benjamin Kramer <benny.kra@googlemail.com> | 2014-02-25 18:03:55 +0000 |
---|---|---|
committer | Benjamin Kramer <benny.kra@googlemail.com> | 2014-02-25 18:03:55 +0000 |
commit | 00e8a1915a258bf02edae8a349a1d751362fe979 (patch) | |
tree | db582f07657d16c2583788fd2f43d3d97f50854e | |
parent | 8e38871865530e38c1a9740443a73ac07957e7dc (diff) | |
download | bcm5719-llvm-00e8a1915a258bf02edae8a349a1d751362fe979.tar.gz bcm5719-llvm-00e8a1915a258bf02edae8a349a1d751362fe979.zip |
Reapply "Pretty Printer: Fix printing of conversion operator decls and calls."
There were many additional tests that had the bad behavior baked in.
llvm-svn: 202174
-rw-r--r-- | clang/lib/AST/DeclPrinter.cpp | 10 | ||||
-rw-r--r-- | clang/lib/AST/DeclarationName.cpp | 2 | ||||
-rw-r--r-- | clang/lib/AST/StmtPrinter.cpp | 6 | ||||
-rw-r--r-- | clang/test/Analysis/auto-obj-dtors-cfg-output.cpp | 16 | ||||
-rw-r--r-- | clang/test/Analysis/temp-obj-dtors-cfg-output.cpp | 92 | ||||
-rw-r--r-- | clang/test/Index/comment-to-html-xml-conversion.cpp | 2 | ||||
-rw-r--r-- | clang/test/SemaCXX/ast-print.cpp | 25 | ||||
-rw-r--r-- | clang/unittests/AST/DeclPrinterTest.cpp | 9 |
8 files changed, 95 insertions, 67 deletions
diff --git a/clang/lib/AST/DeclPrinter.cpp b/clang/lib/AST/DeclPrinter.cpp index aa753887a21..05701a5b061 100644 --- a/clang/lib/AST/DeclPrinter.cpp +++ b/clang/lib/AST/DeclPrinter.cpp @@ -385,6 +385,7 @@ void DeclPrinter::VisitEnumConstantDecl(EnumConstantDecl *D) { void DeclPrinter::VisitFunctionDecl(FunctionDecl *D) { CXXConstructorDecl *CDecl = dyn_cast<CXXConstructorDecl>(D); + CXXConversionDecl *ConversionDecl = dyn_cast<CXXConversionDecl>(D); if (!Policy.SuppressSpecifiers) { switch (D->getStorageClass()) { case SC_None: break; @@ -398,7 +399,8 @@ void DeclPrinter::VisitFunctionDecl(FunctionDecl *D) { if (D->isInlineSpecified()) Out << "inline "; if (D->isVirtualAsWritten()) Out << "virtual "; if (D->isModulePrivate()) Out << "__module_private__ "; - if (CDecl && CDecl->isExplicitSpecified()) + if ((CDecl && CDecl->isExplicitSpecified()) || + (ConversionDecl && ConversionDecl->isExplicit())) Out << "explicit "; } @@ -536,15 +538,15 @@ void DeclPrinter::VisitFunctionDecl(FunctionDecl *D) { } Out << ")"; } - if (!Proto.empty()) - Out << Proto; - } else { + } else if (!ConversionDecl) { if (FT && FT->hasTrailingReturn()) { Out << "auto " << Proto << " -> "; Proto.clear(); } AFT->getReturnType().print(Out, Policy, Proto); + Proto.clear(); } + Out << Proto; } else { Ty.print(Out, Policy, Proto); } diff --git a/clang/lib/AST/DeclarationName.cpp b/clang/lib/AST/DeclarationName.cpp index e5019ab8d9f..f9041c043c9 100644 --- a/clang/lib/AST/DeclarationName.cpp +++ b/clang/lib/AST/DeclarationName.cpp @@ -191,6 +191,7 @@ raw_ostream &operator<<(raw_ostream &OS, DeclarationName N) { return OS << *Rec->getDecl(); LangOptions LO; LO.CPlusPlus = true; + LO.Bool = true; return OS << Type.getAsString(PrintingPolicy(LO)); } case DeclarationName::CXXUsingDirective: @@ -546,6 +547,7 @@ void DeclarationNameInfo::printName(raw_ostream &OS) const { OS << "operator "; LangOptions LO; LO.CPlusPlus = true; + LO.Bool = true; OS << TInfo->getType().getAsString(PrintingPolicy(LO)); } else OS << Name; diff --git a/clang/lib/AST/StmtPrinter.cpp b/clang/lib/AST/StmtPrinter.cpp index 8ed2987e6dd..a9f49990ee5 100644 --- a/clang/lib/AST/StmtPrinter.cpp +++ b/clang/lib/AST/StmtPrinter.cpp @@ -1296,6 +1296,12 @@ void StmtPrinter::VisitCXXOperatorCallExpr(CXXOperatorCallExpr *Node) { } void StmtPrinter::VisitCXXMemberCallExpr(CXXMemberCallExpr *Node) { + // If we have a conversion operator call only print the argument. + CXXMethodDecl *MD = Node->getMethodDecl(); + if (MD && isa<CXXConversionDecl>(MD)) { + PrintExpr(Node->getImplicitObjectArgument()); + return; + } VisitCallExpr(cast<CallExpr>(Node)); } diff --git a/clang/test/Analysis/auto-obj-dtors-cfg-output.cpp b/clang/test/Analysis/auto-obj-dtors-cfg-output.cpp index 0dbbfb592f7..0b4454fbd95 100644 --- a/clang/test/Analysis/auto-obj-dtors-cfg-output.cpp +++ b/clang/test/Analysis/auto-obj-dtors-cfg-output.cpp @@ -228,7 +228,7 @@ l1: // CHECK-NEXT: 7: b // CHECK-NEXT: 8: [B4.7] (ImplicitCastExpr, NoOp, const class A) // CHECK-NEXT: 9: [B4.8].operator int -// CHECK: 10: [B4.9]() +// CHECK: 10: [B4.8] // CHECK: 11: [B4.10] (ImplicitCastExpr, UserDefinedConversion, int) // CHECK: 12: [B4.11] (ImplicitCastExpr, IntegralToBoolean, _Bool) // CHECK-NEXT: T: if [B4.12] @@ -307,7 +307,7 @@ void test_if_implicit_scope() { // CHECK-NEXT: 7: b // CHECK-NEXT: 8: [B8.7] (ImplicitCastExpr, NoOp, const class A) // CHECK-NEXT: 9: [B8.8].operator int -// CHECK: 10: [B8.9]() +// CHECK: 10: [B8.8] // CHECK: 11: [B8.10] (ImplicitCastExpr, UserDefinedConversion, int) // CHECK: 12: [B8.11] (ImplicitCastExpr, IntegralToBoolean, _Bool) // CHECK-NEXT: T: if [B8.12] @@ -354,7 +354,7 @@ void test_if_jumps() { // CHECK-NEXT: 5: b // CHECK-NEXT: 6: [B4.5] (ImplicitCastExpr, NoOp, const class A) // CHECK-NEXT: 7: [B4.6].operator int -// CHECK-NEXT: 8: [B4.7]() +// CHECK-NEXT: 8: [B4.6] // CHECK-NEXT: 9: [B4.8] (ImplicitCastExpr, UserDefinedConversion, int) // CHECK: 10: [B4.9] (ImplicitCastExpr, IntegralToBoolean, _Bool) // CHECK-NEXT: T: while [B4.10] @@ -440,7 +440,7 @@ void test_while_implicit_scope() { // CHECK-NEXT: 5: b // CHECK-NEXT: 6: [B10.5] (ImplicitCastExpr, NoOp, const class A) // CHECK-NEXT: 7: [B10.6].operator int -// CHECK-NEXT: 8: [B10.7]() +// CHECK-NEXT: 8: [B10.6] // CHECK-NEXT: 9: [B10.8] (ImplicitCastExpr, UserDefinedConversion, int) // CHECK: 10: [B10.9] (ImplicitCastExpr, IntegralToBoolean, _Bool) // CHECK-NEXT: T: while [B10.10] @@ -586,7 +586,7 @@ void test_do_jumps() { // CHECK-NEXT: 7: b // CHECK-NEXT: 8: [B2.7] (ImplicitCastExpr, NoOp, const class A) // CHECK-NEXT: 9: [B2.8].operator int -// CHECK: 10: [B2.9]() +// CHECK: 10: [B2.8] // CHECK: 11: [B2.10] (ImplicitCastExpr, UserDefinedConversion, int) // CHECK-NEXT: T: switch [B2.11] // CHECK-NEXT: Preds (1): B4 @@ -624,7 +624,7 @@ void test_switch_implicit_scope() { // CHECK-NEXT: 7: b // CHECK-NEXT: 8: [B2.7] (ImplicitCastExpr, NoOp, const class A) // CHECK-NEXT: 9: [B2.8].operator int -// CHECK: 10: [B2.9]() +// CHECK: 10: [B2.8] // CHECK: 11: [B2.10] (ImplicitCastExpr, UserDefinedConversion, int) // CHECK-NEXT: T: switch [B2.11] // CHECK-NEXT: Preds (1): B9 @@ -710,7 +710,7 @@ void test_switch_jumps() { // CHECK-NEXT: 5: b // CHECK-NEXT: 6: [B4.5] (ImplicitCastExpr, NoOp, const class A) // CHECK-NEXT: 7: [B4.6].operator int -// CHECK-NEXT: 8: [B4.7]() +// CHECK-NEXT: 8: [B4.6] // CHECK-NEXT: 9: [B4.8] (ImplicitCastExpr, UserDefinedConversion, int) // CHECK: 10: [B4.9] (ImplicitCastExpr, IntegralToBoolean, _Bool) // CHECK-NEXT: T: for (...; [B4.10]; ) @@ -796,7 +796,7 @@ void test_for_implicit_scope() { // CHECK-NEXT: 5: c // CHECK-NEXT: 6: [B10.5] (ImplicitCastExpr, NoOp, const class A) // CHECK-NEXT: 7: [B10.6].operator int -// CHECK-NEXT: 8: [B10.7]() +// CHECK-NEXT: 8: [B10.6] // CHECK-NEXT: 9: [B10.8] (ImplicitCastExpr, UserDefinedConversion, int) // CHECK: 10: [B10.9] (ImplicitCastExpr, IntegralToBoolean, _Bool) // CHECK-NEXT: T: for (...; [B10.10]; ) diff --git a/clang/test/Analysis/temp-obj-dtors-cfg-output.cpp b/clang/test/Analysis/temp-obj-dtors-cfg-output.cpp index 9ae657f7d05..328b8d2ff3c 100644 --- a/clang/test/Analysis/temp-obj-dtors-cfg-output.cpp +++ b/clang/test/Analysis/temp-obj-dtors-cfg-output.cpp @@ -211,17 +211,17 @@ void test_noreturn2() { // CHECK: 1: A() (CXXConstructExpr, class A) // CHECK: 2: [B1.1] (BindTemporary) // CHECK: 3: [B1.2].operator int -// CHECK: 4: [B1.3]() +// CHECK: 4: [B1.2] // CHECK: 5: [B1.4] (ImplicitCastExpr, UserDefinedConversion, int) // CHECK: 6: int([B1.5]) (CXXFunctionalCastExpr, NoOp, int) // CHECK: 7: B() (CXXConstructExpr, class B) // CHECK: 8: [B1.7] (BindTemporary) // CHECK: 9: [B1.8].operator int -// CHECK: 10: [B1.9]() +// CHECK: 10: [B1.8] // CHECK: 11: [B1.10] (ImplicitCastExpr, UserDefinedConversion, int) // CHECK: 12: int([B1.11]) (CXXFunctionalCastExpr, NoOp, int) // CHECK: 13: [B1.6] + [B1.12] -// CHECK: 14: int a = int(A().operator int()) + int(B().operator int()); +// CHECK: 14: int a = int(A()) + int(B()); // CHECK: 15: ~B() (Temporary object destructor) // CHECK: 16: ~A() (Temporary object destructor) // CHECK: 17: foo @@ -229,13 +229,13 @@ void test_noreturn2() { // CHECK: 19: A() (CXXConstructExpr, class A) // CHECK: 20: [B1.19] (BindTemporary) // CHECK: 21: [B1.20].operator int -// CHECK: 22: [B1.21]() +// CHECK: 22: [B1.20] // CHECK: 23: [B1.22] (ImplicitCastExpr, UserDefinedConversion, int) // CHECK: 24: int([B1.23]) (CXXFunctionalCastExpr, NoOp, int) // CHECK: 25: B() (CXXConstructExpr, class B) // CHECK: 26: [B1.25] (BindTemporary) // CHECK: 27: [B1.26].operator int -// CHECK: 28: [B1.27]() +// CHECK: 28: [B1.26] // CHECK: 29: [B1.28] (ImplicitCastExpr, UserDefinedConversion, int) // CHECK: 30: int([B1.29]) (CXXFunctionalCastExpr, NoOp, int) // CHECK: 31: [B1.24] + [B1.30] @@ -267,8 +267,8 @@ void test_noreturn2() { // CHECK: [B4] // CHECK: 1: B() (CXXConstructExpr, class B) // CHECK: 2: [B4.1] (BindTemporary) -// CHECK: 3: [B4.2].operator _Bool -// CHECK: 4: [B4.3]() +// CHECK: 3: [B4.2].operator bool +// CHECK: 4: [B4.2] // CHECK: 5: [B4.4] (ImplicitCastExpr, UserDefinedConversion, _Bool) // CHECK: Preds (1): B5 // CHECK: Succs (1): B3 @@ -278,8 +278,8 @@ void test_noreturn2() { // CHECK: 3: [B5.2] (ImplicitCastExpr, FunctionToPointerDecay, void (*)(_Bool)) // CHECK: 4: A() (CXXConstructExpr, class A) // CHECK: 5: [B5.4] (BindTemporary) -// CHECK: 6: [B5.5].operator _Bool -// CHECK: 7: [B5.6]() +// CHECK: 6: [B5.5].operator bool +// CHECK: 7: [B5.5] // CHECK: 8: [B5.7] (ImplicitCastExpr, UserDefinedConversion, _Bool) // CHECK: T: [B5.8] && ... // CHECK: Preds (2): B6 B7 @@ -290,23 +290,23 @@ void test_noreturn2() { // CHECK: Succs (1): B5 // CHECK: [B7] // CHECK: 1: [B9.5] && [B8.5] -// CHECK: 2: bool a = A().operator _Bool() && B().operator _Bool(); +// CHECK: 2: bool a = A() && B(); // CHECK: T: [B9.5] && ... // CHECK: Preds (2): B8 B9 // CHECK: Succs (2): B6 B5 // CHECK: [B8] // CHECK: 1: B() (CXXConstructExpr, class B) // CHECK: 2: [B8.1] (BindTemporary) -// CHECK: 3: [B8.2].operator _Bool -// CHECK: 4: [B8.3]() +// CHECK: 3: [B8.2].operator bool +// CHECK: 4: [B8.2] // CHECK: 5: [B8.4] (ImplicitCastExpr, UserDefinedConversion, _Bool) // CHECK: Preds (1): B9 // CHECK: Succs (1): B7 // CHECK: [B9] // CHECK: 1: A() (CXXConstructExpr, class A) // CHECK: 2: [B9.1] (BindTemporary) -// CHECK: 3: [B9.2].operator _Bool -// CHECK: 4: [B9.3]() +// CHECK: 3: [B9.2].operator bool +// CHECK: 4: [B9.2] // CHECK: 5: [B9.4] (ImplicitCastExpr, UserDefinedConversion, _Bool) // CHECK: T: [B9.5] && ... // CHECK: Preds (1): B10 @@ -333,8 +333,8 @@ void test_noreturn2() { // CHECK: [B4] // CHECK: 1: B() (CXXConstructExpr, class B) // CHECK: 2: [B4.1] (BindTemporary) -// CHECK: 3: [B4.2].operator _Bool -// CHECK: 4: [B4.3]() +// CHECK: 3: [B4.2].operator bool +// CHECK: 4: [B4.2] // CHECK: 5: [B4.4] (ImplicitCastExpr, UserDefinedConversion, _Bool) // CHECK: Preds (1): B5 // CHECK: Succs (1): B3 @@ -344,8 +344,8 @@ void test_noreturn2() { // CHECK: 3: [B5.2] (ImplicitCastExpr, FunctionToPointerDecay, void (*)(_Bool)) // CHECK: 4: A() (CXXConstructExpr, class A) // CHECK: 5: [B5.4] (BindTemporary) -// CHECK: 6: [B5.5].operator _Bool -// CHECK: 7: [B5.6]() +// CHECK: 6: [B5.5].operator bool +// CHECK: 7: [B5.5] // CHECK: 8: [B5.7] (ImplicitCastExpr, UserDefinedConversion, _Bool) // CHECK: T: [B5.8] || ... // CHECK: Preds (2): B6 B7 @@ -356,23 +356,23 @@ void test_noreturn2() { // CHECK: Succs (1): B5 // CHECK: [B7] // CHECK: 1: [B9.5] || [B8.5] -// CHECK: 2: bool a = A().operator _Bool() || B().operator _Bool(); +// CHECK: 2: bool a = A() || B(); // CHECK: T: [B9.5] || ... // CHECK: Preds (2): B8 B9 // CHECK: Succs (2): B5 B6 // CHECK: [B8] // CHECK: 1: B() (CXXConstructExpr, class B) // CHECK: 2: [B8.1] (BindTemporary) -// CHECK: 3: [B8.2].operator _Bool -// CHECK: 4: [B8.3]() +// CHECK: 3: [B8.2].operator bool +// CHECK: 4: [B8.2] // CHECK: 5: [B8.4] (ImplicitCastExpr, UserDefinedConversion, _Bool) // CHECK: Preds (1): B9 // CHECK: Succs (1): B7 // CHECK: [B9] // CHECK: 1: A() (CXXConstructExpr, class A) // CHECK: 2: [B9.1] (BindTemporary) -// CHECK: 3: [B9.2].operator _Bool -// CHECK: 4: [B9.3]() +// CHECK: 3: [B9.2].operator bool +// CHECK: 4: [B9.2] // CHECK: 5: [B9.4] (ImplicitCastExpr, UserDefinedConversion, _Bool) // CHECK: T: [B9.5] || ... // CHECK: Preds (1): B10 @@ -404,8 +404,8 @@ void test_noreturn2() { // CHECK: 1: ~B() (Temporary object destructor) // CHECK: 2: B() (CXXConstructExpr, class B) // CHECK: 3: [B4.2] (BindTemporary) -// CHECK: 4: [B4.3].operator _Bool -// CHECK: 5: [B4.4]() +// CHECK: 4: [B4.3].operator bool +// CHECK: 5: [B4.3] // CHECK: 6: [B4.5] (ImplicitCastExpr, UserDefinedConversion, _Bool) // CHECK: 7: ~B() (Temporary object destructor) // CHECK: T: if [B4.6] @@ -428,7 +428,7 @@ void test_noreturn2() { // CHECK: 2: [B7.1] (ImplicitCastExpr, NoOp, const class A) // CHECK: 3: [B7.2] // CHECK: 4: [B7.3] (CXXConstructExpr, class A) -// CHECK: 5: A a = B().operator _Bool() ? A() : A(B().operator A()); +// CHECK: 5: A a = B() ? A() : A(B()); // CHECK: T: [B10.5] ? ... : ... // CHECK: Preds (2): B8 B9 // CHECK: Succs (2): B5 B6 @@ -445,7 +445,7 @@ void test_noreturn2() { // CHECK: 1: B() (CXXConstructExpr, class B) // CHECK: 2: [B9.1] (BindTemporary) // CHECK: 3: [B9.2].operator A -// CHECK: 4: [B9.3]() +// CHECK: 4: [B9.2] // CHECK: 5: [B9.4] (ImplicitCastExpr, UserDefinedConversion, class A) // CHECK: 6: [B9.5] (BindTemporary) // CHECK: 7: [B9.6] (ImplicitCastExpr, NoOp, const class A) @@ -462,8 +462,8 @@ void test_noreturn2() { // CHECK: [B10] // CHECK: 1: B() (CXXConstructExpr, class B) // CHECK: 2: [B10.1] (BindTemporary) -// CHECK: 3: [B10.2].operator _Bool -// CHECK: 4: [B10.3]() +// CHECK: 3: [B10.2].operator bool +// CHECK: 4: [B10.2] // CHECK: 5: [B10.4] (ImplicitCastExpr, UserDefinedConversion, _Bool) // CHECK: T: [B10.5] ? ... : ... // CHECK: Preds (1): B11 @@ -511,7 +511,7 @@ void test_noreturn2() { // CHECK: 1: B() (CXXConstructExpr, class B) // CHECK: 2: [B6.1] (BindTemporary) // CHECK: 3: [B6.2].operator A -// CHECK: 4: [B6.3]() +// CHECK: 4: [B6.2] // CHECK: 5: [B6.4] (ImplicitCastExpr, UserDefinedConversion, class A) // CHECK: 6: [B6.5] (BindTemporary) // CHECK: 7: [B6.6] (ImplicitCastExpr, NoOp, const class A) @@ -531,8 +531,8 @@ void test_noreturn2() { // CHECK: 3: [B7.2] (ImplicitCastExpr, FunctionToPointerDecay, void (*)(const class A &)) // CHECK: 4: B() (CXXConstructExpr, class B) // CHECK: 5: [B7.4] (BindTemporary) -// CHECK: 6: [B7.5].operator _Bool -// CHECK: 7: [B7.6]() +// CHECK: 6: [B7.5].operator bool +// CHECK: 7: [B7.5] // CHECK: 8: [B7.7] (ImplicitCastExpr, UserDefinedConversion, _Bool) // CHECK: T: [B7.8] ? ... : ... // CHECK: Preds (2): B8 B9 @@ -551,7 +551,7 @@ void test_noreturn2() { // CHECK: 1: [B13.5] ? [B11.6] : [B12.15] // CHECK: 2: [B10.1] (ImplicitCastExpr, NoOp, const class A) // CHECK: 3: [B10.2] -// CHECK: 4: const A &a = B().operator _Bool() ? A() : A(B().operator A()); +// CHECK: 4: const A &a = B() ? A() : A(B()); // CHECK: T: [B13.5] ? ... : ... // CHECK: Preds (2): B11 B12 // CHECK: Succs (2): B8 B9 @@ -568,7 +568,7 @@ void test_noreturn2() { // CHECK: 1: B() (CXXConstructExpr, class B) // CHECK: 2: [B12.1] (BindTemporary) // CHECK: 3: [B12.2].operator A -// CHECK: 4: [B12.3]() +// CHECK: 4: [B12.2] // CHECK: 5: [B12.4] (ImplicitCastExpr, UserDefinedConversion, class A) // CHECK: 6: [B12.5] (BindTemporary) // CHECK: 7: [B12.6] (ImplicitCastExpr, NoOp, const class A) @@ -585,8 +585,8 @@ void test_noreturn2() { // CHECK: [B13] // CHECK: 1: B() (CXXConstructExpr, class B) // CHECK: 2: [B13.1] (BindTemporary) -// CHECK: 3: [B13.2].operator _Bool -// CHECK: 4: [B13.3]() +// CHECK: 3: [B13.2].operator bool +// CHECK: 4: [B13.2] // CHECK: 5: [B13.4] (ImplicitCastExpr, UserDefinedConversion, _Bool) // CHECK: T: [B13.5] ? ... : ... // CHECK: Preds (1): B14 @@ -638,8 +638,8 @@ void test_noreturn2() { // CHECK: [B7] // CHECK: 1: A() (CXXConstructExpr, class A) // CHECK: 2: [B7.1] (BindTemporary) -// CHECK: 3: [B7.2].operator _Bool -// CHECK: 4: [B7.3]() +// CHECK: 3: [B7.2].operator bool +// CHECK: 4: [B7.2] // CHECK: 5: [B7.4] (ImplicitCastExpr, UserDefinedConversion, _Bool) // CHECK: T: [B7.5] ? ... : ... // CHECK: Preds (1): B8 @@ -693,8 +693,8 @@ void test_noreturn2() { // CHECK: 3: [B7.2] (ImplicitCastExpr, FunctionToPointerDecay, void (*)(const class A &)) // CHECK: 4: A() (CXXConstructExpr, class A) // CHECK: 5: [B7.4] (BindTemporary) -// CHECK: 6: [B7.5].operator _Bool -// CHECK: 7: [B7.6]() +// CHECK: 6: [B7.5].operator bool +// CHECK: 7: [B7.5] // CHECK: 8: [B7.7] (ImplicitCastExpr, UserDefinedConversion, _Bool) // CHECK: T: [B7.8] ? ... : ... // CHECK: Preds (2): B9 B8 @@ -730,8 +730,8 @@ void test_noreturn2() { // CHECK: [B12] // CHECK: 1: A() (CXXConstructExpr, class A) // CHECK: 2: [B12.1] (BindTemporary) -// CHECK: 3: [B12.2].operator _Bool -// CHECK: 4: [B12.3]() +// CHECK: 3: [B12.2].operator bool +// CHECK: 4: [B12.2] // CHECK: 5: [B12.4] (ImplicitCastExpr, UserDefinedConversion, _Bool) // CHECK: T: [B12.5] ? ... : ... // CHECK: Preds (1): B13 @@ -827,7 +827,7 @@ void test_noreturn2() { // CHECK: 2: A() (CXXConstructExpr, class A) // CHECK: 3: [B1.2] (BindTemporary) // CHECK: 4: [B1.3].operator int -// CHECK: 5: [B1.4]() +// CHECK: 5: [B1.3] // CHECK: 6: [B1.5] (ImplicitCastExpr, UserDefinedConversion, int) // CHECK: 7: a // CHECK: 8: [B1.7] = [B1.6] @@ -843,13 +843,13 @@ void test_noreturn2() { // CHECK: 1: A() (CXXConstructExpr, class A) // CHECK: 2: [B1.1] (BindTemporary) // CHECK: 3: [B1.2].operator int -// CHECK: 4: [B1.3]() +// CHECK: 4: [B1.2] // CHECK: 5: [B1.4] (ImplicitCastExpr, UserDefinedConversion, int) // CHECK: 6: int([B1.5]) (CXXFunctionalCastExpr, NoOp, int) // CHECK: 7: B() (CXXConstructExpr, class B) // CHECK: 8: [B1.7] (BindTemporary) // CHECK: 9: [B1.8].operator int -// CHECK: 10: [B1.9]() +// CHECK: 10: [B1.8] // CHECK: 11: [B1.10] (ImplicitCastExpr, UserDefinedConversion, int) // CHECK: 12: int([B1.11]) (CXXFunctionalCastExpr, NoOp, int) // CHECK: 13: [B1.6] + [B1.12] @@ -862,7 +862,6 @@ void test_noreturn2() { // CHECK: Succs (1): B0 // CHECK: [B0 (EXIT)] // CHECK: Preds (1): B1 - // CHECK: [B3 (ENTRY)] // CHECK: Succs (1): B2 // CHECK: [B1] @@ -879,7 +878,6 @@ void test_noreturn2() { // CHECK: Succs (1): B0 // CHECK: [B0 (EXIT)] // CHECK: Preds (2): B1 B2 - // CHECK: [B3 (ENTRY)] // CHECK: Succs (1): B2 // CHECK: [B1] diff --git a/clang/test/Index/comment-to-html-xml-conversion.cpp b/clang/test/Index/comment-to-html-xml-conversion.cpp index 43737b8ade9..697f91c9cb4 100644 --- a/clang/test/Index/comment-to-html-xml-conversion.cpp +++ b/clang/test/Index/comment-to-html-xml-conversion.cpp @@ -764,7 +764,7 @@ class comment_to_xml_conversion_01 { /// Aaa. operator bool(); -// CHECK: comment-to-html-xml-conversion.cpp:[[@LINE-2]]:3: CXXConversion=operator _Bool:{{.*}} FullCommentAsXML=[<Function isInstanceMethod="1" file="{{[^"]+}}comment-to-html-xml-conversion.cpp" line="[[@LINE-2]]" column="3"><Name>operator _Bool</Name><USR>c:@C@comment_to_xml_conversion_01@F@operator _Bool#</USR><Declaration>bool operator _Bool()</Declaration><Abstract><Para> Aaa.</Para></Abstract></Function>] +// CHECK: comment-to-html-xml-conversion.cpp:[[@LINE-2]]:3: CXXConversion=operator bool:{{.*}} FullCommentAsXML=[<Function isInstanceMethod="1" file="{{[^"]+}}comment-to-html-xml-conversion.cpp" line="[[@LINE-2]]" column="3"><Name>operator bool</Name><USR>c:@C@comment_to_xml_conversion_01@F@operator bool#</USR><Declaration>operator bool()</Declaration><Abstract><Para> Aaa.</Para></Abstract></Function>] /// Aaa. typedef int comment_to_xml_conversion_06; diff --git a/clang/test/SemaCXX/ast-print.cpp b/clang/test/SemaCXX/ast-print.cpp index 977ba7afa4d..3d98fd8ef3a 100644 --- a/clang/test/SemaCXX/ast-print.cpp +++ b/clang/test/SemaCXX/ast-print.cpp @@ -1,4 +1,4 @@ -// RUN: %clang_cc1 -ast-print %s | FileCheck %s +// RUN: %clang_cc1 -ast-print %s -std=gnu++11 | FileCheck %s // CHECK: r; // CHECK-NEXT: (r->method()); @@ -173,3 +173,26 @@ void test14() { float test15() { return __builtin_asinf(1.0F); } + +namespace PR18776 { +struct A { + operator void *(); + explicit operator bool(); + A operator&(A); +}; + +// CHECK: struct A +// CHECK-NEXT: {{^[ ]*operator}} void *(); +// CHECK-NEXT: {{^[ ]*explicit}} operator bool(); + +void bar(void *); + +void foo() { + A a, b; + bar(a & b); +// CHECK: bar(a & b); + if (a & b) +// CHECK: if (a & b) + return; +} +}; diff --git a/clang/unittests/AST/DeclPrinterTest.cpp b/clang/unittests/AST/DeclPrinterTest.cpp index 570a807dcb4..34739f7e8a0 100644 --- a/clang/unittests/AST/DeclPrinterTest.cpp +++ b/clang/unittests/AST/DeclPrinterTest.cpp @@ -549,8 +549,7 @@ TEST(DeclPrinter, TestCXXConversionDecl1) { " operator int();" "};", methodDecl(ofClass(hasName("A"))).bind("id"), - "int operator int()")); - // WRONG; Should be: "operator int();" + "operator int()")); } TEST(DeclPrinter, TestCXXConversionDecl2) { @@ -559,8 +558,7 @@ TEST(DeclPrinter, TestCXXConversionDecl2) { " operator bool();" "};", methodDecl(ofClass(hasName("A"))).bind("id"), - "bool operator _Bool()")); - // WRONG; Should be: "operator bool();" + "operator bool()")); } TEST(DeclPrinter, TestCXXConversionDecl3) { @@ -570,8 +568,7 @@ TEST(DeclPrinter, TestCXXConversionDecl3) { " operator Z();" "};", methodDecl(ofClass(hasName("A"))).bind("id"), - "Z operator Z()")); - // WRONG; Should be: "operator Z();" + "operator Z()")); } TEST(DeclPrinter, TestCXXMethodDecl_AllocationFunction1) { |