diff options
| author | Chandler Carruth <chandlerc@gmail.com> | 2010-01-31 10:26:25 +0000 |
|---|---|---|
| committer | Chandler Carruth <chandlerc@gmail.com> | 2010-01-31 10:26:25 +0000 |
| commit | 00216980fb655d4323e4a4394dfbebd72ae9a130 (patch) | |
| tree | 309d249879b0c6ec8759d7c535dbe18063de0271 | |
| parent | 724a8a1fef4697c4ab8188cc89934a2a4b05fd34 (diff) | |
| download | bcm5719-llvm-00216980fb655d4323e4a4394dfbebd72ae9a130.tar.gz bcm5719-llvm-00216980fb655d4323e4a4394dfbebd72ae9a130.zip | |
Really trivial patch to accept pointer to const void in indirect goto. Despite
the lack of documentation, this matches the behavior of GCC.
llvm-svn: 94954
| -rw-r--r-- | clang/lib/Sema/SemaStmt.cpp | 6 | ||||
| -rw-r--r-- | clang/test/Sema/indirect-goto.c | 3 |
2 files changed, 6 insertions, 3 deletions
diff --git a/clang/lib/Sema/SemaStmt.cpp b/clang/lib/Sema/SemaStmt.cpp index 7fefcf2764d..a75003bf3f5 100644 --- a/clang/lib/Sema/SemaStmt.cpp +++ b/clang/lib/Sema/SemaStmt.cpp @@ -906,10 +906,10 @@ Sema::ActOnIndirectGotoStmt(SourceLocation GotoLoc, SourceLocation StarLoc, Expr* E = DestExp.takeAs<Expr>(); if (!E->isTypeDependent()) { QualType ETy = E->getType(); + QualType DestTy = Context.getPointerType(Context.VoidTy.withConst()); AssignConvertType ConvTy = - CheckSingleAssignmentConstraints(Context.VoidPtrTy, E); - if (DiagnoseAssignmentResult(ConvTy, StarLoc, Context.VoidPtrTy, ETy, - E, AA_Passing)) + CheckSingleAssignmentConstraints(DestTy, E); + if (DiagnoseAssignmentResult(ConvTy, StarLoc, DestTy, ETy, E, AA_Passing)) return StmtError(); } return Owned(new (Context) IndirectGotoStmt(GotoLoc, StarLoc, E)); diff --git a/clang/test/Sema/indirect-goto.c b/clang/test/Sema/indirect-goto.c index 134ccd8a707..4c1c6c328a1 100644 --- a/clang/test/Sema/indirect-goto.c +++ b/clang/test/Sema/indirect-goto.c @@ -2,6 +2,9 @@ struct c {int x;}; int a(struct c x, long long y) { + void const* l1_ptr = &&l1; + goto *l1_ptr; +l1: goto *x; // expected-error{{incompatible type}} goto *y; // expected-warning{{incompatible integer to pointer conversion}} } |

