summaryrefslogtreecommitdiffstats
path: root/support/scripts/graph-depends
diff options
context:
space:
mode:
authorThomas De Schampheleire <thomas.de_schampheleire@nokia.com>2017-02-03 21:57:45 +0100
committerThomas Petazzoni <thomas.petazzoni@free-electrons.com>2017-02-06 12:28:00 +0100
commit412e6c80ad56181546f29f2add405fa595116271 (patch)
treef3634664fca3b0c935d8d9d72b3bfcac84605f69 /support/scripts/graph-depends
parent12683184b1969f65680cb7db55b547a620a9860f (diff)
downloadbuildroot-412e6c80ad56181546f29f2add405fa595116271.tar.gz
buildroot-412e6c80ad56181546f29f2add405fa595116271.zip
graph-depends: split off get_rdepends from get_depends
The use of a 'rule' variable that can contain 'show-depends' or 'show-rdepends' is not logical if get_depends is considered as a reusable function from various scripts. The name of these rules are too much an implementation detail. Therefore, split the existing get_depends into two separate functions get_depends and get_rdepends, while keeping code duplication to a minimum. Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Diffstat (limited to 'support/scripts/graph-depends')
-rwxr-xr-xsupport/scripts/graph-depends6
1 files changed, 3 insertions, 3 deletions
diff --git a/support/scripts/graph-depends b/support/scripts/graph-depends
index 7aedcb5184..fbd5917053 100755
--- a/support/scripts/graph-depends
+++ b/support/scripts/graph-depends
@@ -102,13 +102,13 @@ else:
transitive = args.transitive
if args.direct:
- rule = "show-depends"
+ get_depends_func = pkgutil.get_depends
arrow_dir = "forward"
else:
if mode == MODE_FULL:
sys.stderr.write("--reverse needs a package\n")
sys.exit(1)
- rule = "show-rdepends"
+ get_depends_func = pkgutil.get_rdepends
arrow_dir = "back"
# Get the colours: we need exactly three colours,
@@ -157,7 +157,7 @@ def get_all_depends(pkgs):
if len(filtered_pkgs) == 0:
return []
- depends = pkgutil.get_depends(filtered_pkgs, rule)
+ depends = get_depends_func(filtered_pkgs)
deps = set()
for pkg in filtered_pkgs:
OpenPOWER on IntegriCloud