diff options
author | Peter Korsgaard <peter@korsgaard.com> | 2018-03-12 23:36:03 +0100 |
---|---|---|
committer | Peter Korsgaard <peter@korsgaard.com> | 2018-03-14 08:39:12 +0100 |
commit | 32d2de2a6fb823a8eacb02d203b260c729522837 (patch) | |
tree | d41aed116c1bc9ee2dfb4ea2b5a7558156531874 /package/xfsprogs/0003-workqueue-add-missing-pthreads-header.patch | |
parent | ed0d9d6f36dfc3e99ee70cc34de0c380925e871f (diff) | |
download | buildroot-32d2de2a6fb823a8eacb02d203b260c729522837.tar.gz buildroot-32d2de2a6fb823a8eacb02d203b260c729522837.zip |
pkg-virtual.mk: explicitly set <pkg>_VERSION / _SOURCE for robustness
Recently a build failure was reported which was traced back to to the fact
that the user had a TOOLCHAIN_VERSION environment variable set which leads
to a strange looking error message:
toolchain/toolchain/toolchain.mk:40: *** TOOLCHAIN_SITE cannot be empty when
TOOLCHAIN_SOURCE is not. Stop.
Environment variables automatically gets converted to make variables by GNU
make - E.G. from the manual
(https://www.gnu.org/software/make/manual/html_node/Environment.html):
Variables in make can come from the environment in which make is run. Every
environment variable that make sees when it starts up is transformed into a
make variable with the same name and value
So we end up in make with TOOLCHAIN_VERSION set to the value of the
environment variable. As virtual packages do not have a version, there is
no explicit TOOLCHAIN_VERSION = .. line in toolchain.mk overriding this
value, and the logic in package/pkg-generic.mk sets a default value for
TOOLCHAIN_SOURCE when TOOLCHAIN_VERSION is set, and finally errors out as
TOOLCHAIN_SITE isn't set.
As a workaround, explicitly set <pkg>_VERSION and <pkg>_SOURCE to the empty
string in the virtual package infrastructure.
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Diffstat (limited to 'package/xfsprogs/0003-workqueue-add-missing-pthreads-header.patch')
0 files changed, 0 insertions, 0 deletions