diff options
| author | Jörg Krause <jkrause@posteo.de> | 2015-01-12 21:52:01 +0100 |
|---|---|---|
| committer | Thomas Petazzoni <thomas.petazzoni@free-electrons.com> | 2015-01-12 22:03:17 +0100 |
| commit | 4f09b5b484af374b86af0db9e171f22fffffc8f0 (patch) | |
| tree | cf8dfeda1bcd81ddb010ca7b3a3f3a4f9ae3db47 /package/nodejs | |
| parent | e27ccbabc1fe5cafdd0b56098bb04e7213319002 (diff) | |
| download | buildroot-4f09b5b484af374b86af0db9e171f22fffffc8f0.tar.gz buildroot-4f09b5b484af374b86af0db9e171f22fffffc8f0.zip | |
package/nodejs: fix hard float error
Add support for building nodejs with hard floating ABI if supported by the
target and remove bogus comment. Buildroot does propose this tuning.
Basically, you have three cases of floating point strategies:
* soft float, i.e 'soft' in nodejs speak. This is enabled in Buildroot
when BR2_ARM_EABI=y and BR2_SOFT_FLOAT=y.
* hard float using integer registers to pass floating point arguments,
i.e 'softfp' in nodejs speak. This is enabled in Buildroot when
BR2_ARM_EABI=y and BR2_SOFT_FLOAT is disabled.
* hard float using floating pointer registers to pass floating point
arguments, i.e 'hard' in nodejs speak. This is enabled in Buildroot
when BR2_ARM_EABIHF=y.
This patch fixes "[Buildroot] Float error on SAMA5D3 Xplained using nodejs":
http://lists.busybox.net/pipermail/buildroot/2014-December/114254.html
Tested at run-time by me on a TI Beaglebone Black.
[Thomas: add qstrip call when using the BR2_GCC_TARGET_FLOAT_ABI
variable.]
Signed-off-by: Jörg Krause <jkrause@posteo.de>
Reported-by: Cédric Heyman <c.heyman@til-technologies.fr>
Suggested-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Diffstat (limited to 'package/nodejs')
| -rw-r--r-- | package/nodejs/nodejs.mk | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/package/nodejs/nodejs.mk b/package/nodejs/nodejs.mk index ad598d9a2d..c2cb05ed00 100644 --- a/package/nodejs/nodejs.mk +++ b/package/nodejs/nodejs.mk @@ -56,14 +56,8 @@ else ifeq ($(BR2_mipsel),y) NODEJS_CPU = mipsel else ifeq ($(BR2_arm),y) NODEJS_CPU = arm -# V8 needs to know what floating point ABI the target is using. There's also -# a 'hard' option which we're not exposing here at the moment, because -# buildroot itself doesn't really support it at present. -ifeq ($(BR2_SOFT_FLOAT),y) -NODEJS_ARM_FP = soft -else -NODEJS_ARM_FP = softfp -endif +# V8 needs to know what floating point ABI the target is using. +NODEJS_ARM_FP = $(call qstrip,$(BR2_GCC_TARGET_FLOAT_ABI)) endif define NODEJS_CONFIGURE_CMDS |
