diff options
| author | Yann E. MORIN <yann.morin.1998@free.fr> | 2015-06-28 14:27:29 +0200 |
|---|---|---|
| committer | Thomas Petazzoni <thomas.petazzoni@free-electrons.com> | 2015-07-04 15:30:25 +0200 |
| commit | ee435eb3f36999dbe55af8dd6aeb82d0abc517b6 (patch) | |
| tree | ea37d62e3c98f10d88e3cf85c4df6d3b14e79e0b | |
| parent | 22b327fc743b48a33aec0a9190bd67118641b294 (diff) | |
| download | buildroot-ee435eb3f36999dbe55af8dd6aeb82d0abc517b6.tar.gz buildroot-ee435eb3f36999dbe55af8dd6aeb82d0abc517b6.zip | |
core/pkg-generic: sanitise FOO_OVERRIDE_SRCDIR
In case FOO_OVERRIDE_SRCDIR has trailing spaces, like so:
FOO_OVERRIDE_SRCDIR = /path/to/sources\x20
we would end up with a rsync command like so:
rsync -au /path/to/sources / /path/to/build/foo
which would effectively rsync the whole vfs, eventually filling the
whole disk... :-(
So, just qstrip the variable before use.
Reported-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
| -rw-r--r-- | package/pkg-generic.mk | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk index d5b29f0821..9fe01b8d4d 100644 --- a/package/pkg-generic.mk +++ b/package/pkg-generic.mk @@ -102,7 +102,7 @@ $(BUILD_DIR)/%/.stamp_rsynced: @$(call MESSAGE,"Syncing from source dir $(SRCDIR)") @test -d $(SRCDIR) || (echo "ERROR: $(SRCDIR) does not exist" ; exit 1) $(foreach hook,$($(PKG)_PRE_RSYNC_HOOKS),$(call $(hook))$(sep)) - rsync -au $(RSYNC_VCS_EXCLUSIONS) $(SRCDIR)/ $(@D) + rsync -au $(RSYNC_VCS_EXCLUSIONS) $(call qstrip,$(SRCDIR))/ $(@D) $(foreach hook,$($(PKG)_POST_RSYNC_HOOKS),$(call $(hook))$(sep)) $(Q)touch $@ |
