summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRomain Naour <romain.naour@smile.fr>2018-01-19 11:15:07 +0100
committerThomas Petazzoni <thomas.petazzoni@bootlin.com>2018-05-03 23:15:06 +0200
commite05e4de693416e7a099fb87097c21e2b32ae5472 (patch)
tree65bed91fe536ddb4d1bcf3b9cd07ed0914eaa671
parent8dbfd500006c630a0299e384965045056fdb4d3b (diff)
downloadbuildroot-e05e4de693416e7a099fb87097c21e2b32ae5472.tar.gz
buildroot-e05e4de693416e7a099fb87097c21e2b32ae5472.zip
package/mksh: add /bin/mksh to /etc/shells
When mksh is selected, /bin/mksh is not added to /etc/shells (see man shells). So, login tools like dropbear reject the ssh connections for users using mksh as shell in /etc/passwd. buildroot authpriv.warn dropbear[853]: User 'kubu' has invalid shell, rejected Signed-off-by: Romain Naour <romain.naour@smile.fr> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
-rw-r--r--package/mksh/mksh.mk8
1 files changed, 8 insertions, 0 deletions
diff --git a/package/mksh/mksh.mk b/package/mksh/mksh.mk
index b5706dbe0f..4fa0e020af 100644
--- a/package/mksh/mksh.mk
+++ b/package/mksh/mksh.mk
@@ -21,4 +21,12 @@ define MKSH_INSTALL_TARGET_CMDS
$(INSTALL) -m 0755 -D $(@D)/mksh $(TARGET_DIR)/bin/mksh
endef
+# Add /bin/mksh to /etc/shells otherwise some login tools like dropbear
+# can reject the user connection. See man shells.
+define MKSH_ADD_MKSH_TO_SHELLS
+ grep -qsE '^/bin/mksh$$' $(TARGET_DIR)/etc/shells \
+ || echo "/bin/mksh" >> $(TARGET_DIR)/etc/shells
+endef
+MKSH_TARGET_FINALIZE_HOOKS += MKSH_ADD_MKSH_TO_SHELLS
+
$(eval $(generic-package))
OpenPOWER on IntegriCloud