summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStefan Sørensen <stefan.sorensen@spectralink.com>2015-02-24 16:47:34 +0100
committerThomas Petazzoni <thomas.petazzoni@free-electrons.com>2015-03-08 22:21:36 +0100
commit6b577b3c3adf7de2582985160ab2906c8dabf22c (patch)
tree2a5bc75ee193a70d75c8bcee7c9d1231221dc57d
parent3ce5f4d27d72bddf6308a829e8e5ed65b124ec1d (diff)
downloadbuildroot-6b577b3c3adf7de2582985160ab2906c8dabf22c.tar.gz
buildroot-6b577b3c3adf7de2582985160ab2906c8dabf22c.zip
fs: Bail out on errors in fakeroot script
Currently, the generated fakeroot script has no error checking causing make to continue building even if some of the fakeroot script commands have failed. This can cause e.g. using an invalid device tables to go unnoticed. So add a "set -e" to the start of the fakeroot script so it will exit with a failure code as soon as one of the script commands fails. Signed-off-by: Stefan Sørensen <stefan.sorensen@spectralink.com> Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
-rw-r--r--fs/common.mk1
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/common.mk b/fs/common.mk
index 13bf4ad77f..1d3926f98c 100644
--- a/fs/common.mk
+++ b/fs/common.mk
@@ -72,6 +72,7 @@ $$(BINARIES_DIR)/rootfs.$(1): target-finalize $$(ROOTFS_$(2)_DEPENDENCIES)
rm -f $$(FAKEROOT_SCRIPT)
rm -f $$(TARGET_DIR_WARNING_FILE)
rm -f $$(USERS_TABLE)
+ echo "set -e" >> $$(FAKEROOT_SCRIPT)
echo "chown -h -R 0:0 $$(TARGET_DIR)" >> $$(FAKEROOT_SCRIPT)
ifneq ($$(ROOTFS_DEVICE_TABLES),)
cat $$(ROOTFS_DEVICE_TABLES) > $$(FULL_DEVICE_TABLE)
OpenPOWER on IntegriCloud