diff options
| author | Yann E. MORIN <yann.morin.1998@free.fr> | 2015-04-01 00:15:06 +0200 |
|---|---|---|
| committer | Thomas Petazzoni <thomas.petazzoni@free-electrons.com> | 2015-04-03 14:08:54 +0200 |
| commit | 327531543288ac17690a36f3d4f2800f2ecc2362 (patch) | |
| tree | 41f306d08cb9b16fafbc3bdf91cba07f09fcf0ff | |
| parent | 3c19d511d79430c9238194b677e69bd15c321307 (diff) | |
| download | buildroot-327531543288ac17690a36f3d4f2800f2ecc2362.tar.gz buildroot-327531543288ac17690a36f3d4f2800f2ecc2362.zip | |
support/download: always fail when there's no hash
At the time we introduced hashes, we did not want to be too harsh in the
beginning, and give people some time to adapt and accept the hashes. So
we so far only whined^Wwarned about a missing hash (when the .hash file
exists).
Some time has passed now, and people are still missing updating hashes
when bumping packages.
Let's make that warning a little bit more annoying...
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Arnout Vandecappelle <arnout@mind.be>
Reviewed-by: Samuel Martin <s.martin49@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
| -rw-r--r-- | docs/manual/adding-packages-directory.txt | 8 | ||||
| -rwxr-xr-x | support/download/check-hash | 8 |
2 files changed, 6 insertions, 10 deletions
diff --git a/docs/manual/adding-packages-directory.txt b/docs/manual/adding-packages-directory.txt index b9e3c52388..f536a0cf4b 100644 --- a/docs/manual/adding-packages-directory.txt +++ b/docs/manual/adding-packages-directory.txt @@ -475,10 +475,10 @@ not match, Buildroot considers this an error, deletes the downloaded file, and aborts. If the +.hash+ file is present, but it does not contain a hash for a -downloaded file, no check is done for that file. If you set the -environment variable +BR2_ENFORCE_CHECK_HASH+ to a non-empty value, and -there is no hash for a downloaded file, Buildroot considers this an -error, deletes the downloaded file, and aborts. +downloaded file, Buildroot considers this an error and aborts. However, +the downloaded file is left in the download directory since this +typically indicates that the +.hash+ file is wrong but the downloaded +file is probably OK. Sources that are downloaded from a version control system (git, subversion, etc...) can not have a hash, because the version control system and tar diff --git a/support/download/check-hash b/support/download/check-hash index ab416c7052..13a76b8df5 100755 --- a/support/download/check-hash +++ b/support/download/check-hash @@ -94,10 +94,6 @@ while read t h f; do done <"${h_file}" if [ ${nb_checks} -eq 0 ]; then - if [ -n "${BR2_ENFORCE_CHECK_HASH}" ]; then - printf "ERROR: No hash found for %s\n" "${base}" >&2 - exit 3 - else - printf "WARNING: No hash found for %s\n" "${base}" >&2 - fi + printf "ERROR: No hash found for %s\n" "${base}" >&2 + exit 3 fi |
