diff options
| author | Jan Heylen <jan.heylen@nokia.com> | 2018-01-04 13:28:29 +0100 |
|---|---|---|
| committer | Thomas Petazzoni <thomas.petazzoni@free-electrons.com> | 2018-01-07 21:54:27 +0100 |
| commit | 2d0058e2d3d5ebc22d4ad4ffaa9a265ba680bf53 (patch) | |
| tree | cf1704188e6e6d211ed791ebf76ce7ed620d21fa | |
| parent | 7022190c4bec602e1ec996cbec92a118010b5b70 (diff) | |
| download | buildroot-2d0058e2d3d5ebc22d4ad4ffaa9a265ba680bf53.tar.gz buildroot-2d0058e2d3d5ebc22d4ad4ffaa9a265ba680bf53.zip | |
package/pkg-cmake.mk: add note about BUILD_STATIC_LIBS
As BUILD_STATIC_LIBS is not a standard cmake variable (while
BUILD_SHARED_LIBS is) we shouldn't add it in pkg-cmake.mk, although
for some packages that would make sense. Therefore, add a note so we
don't forget about this abnormality.
See: https://cmake.org/cmake/help/v3.8/manual/cmake-variables.7.html#variables-that-change-behavior
Signed-off-by: Jan Heylen <jan.heylen@nokia.com>
[Thomas: rework the comment in the code.]
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
| -rw-r--r-- | package/pkg-cmake.mk | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/package/pkg-cmake.mk b/package/pkg-cmake.mk index 6739704e3c..14ffe4a88f 100644 --- a/package/pkg-cmake.mk +++ b/package/pkg-cmake.mk @@ -80,6 +80,14 @@ ifndef $(2)_CONFIGURE_CMDS ifeq ($(4),target) # Configure package for target +# +# - We are passing BUILD_SHARED_LIBS because it is documented as a +# standard CMake variable to control the build of shared libraries +# (see https://cmake.org/cmake/help/v3.8/manual/cmake-variables.7.html#variables-that-change-behavior) +# - We are not passing BUILD_STATIC_LIBS because it is *not* +# documented as a standard CMake variable. If a package supports it, +# it must handle it explicitly. +# define $(2)_CONFIGURE_CMDS (mkdir -p $$($$(PKG)_BUILDDIR) && \ cd $$($$(PKG)_BUILDDIR) && \ |
