diff options
| author | Vasant Hegde <hegdevasant@linux.vnet.ibm.com> | 2015-07-02 14:01:15 +0530 |
|---|---|---|
| committer | Stewart Smith <stewart@linux.vnet.ibm.com> | 2015-07-17 11:45:16 +1000 |
| commit | be8b9c13742ffa4b7c395a1e86b398b01e7bbb79 (patch) | |
| tree | cf16d0dcf1a79cc7ac5890f19fe4e79e7d1ed65a | |
| parent | 2f6c3d6753d5d80643802164864a9502d7bd0acb (diff) | |
| download | talos-skiboot-be8b9c13742ffa4b7c395a1e86b398b01e7bbb79.tar.gz talos-skiboot-be8b9c13742ffa4b7c395a1e86b398b01e7bbb79.zip | |
FSP/LEDS: Remove led-loc property
We added led-loc property.. which contains LED location information.
But this property was never used. Also we can make out LED location
(enclosure/component) based on location code (if location code doesn't
contain "-" means its enclosure location code).
As Ben suggested [1], removing this property.
Present code is included in skiboot skiboot-5.0 release..But we don't
have any consumer yet. Hence I think its fine to make this changes.
[1] https://lists.ozlabs.org/pipermail/linuxppc-dev/2015-June/130433.html
Suggested-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
| -rw-r--r-- | doc/device-tree/ibm,opal/led.txt | 3 | ||||
| -rw-r--r-- | hw/fsp/fsp-leds.c | 7 | ||||
| -rw-r--r-- | include/fsp-leds.h | 5 |
3 files changed, 0 insertions, 15 deletions
diff --git a/doc/device-tree/ibm,opal/led.txt b/doc/device-tree/ibm,opal/led.txt index 00cd32c2..5e48b859 100644 --- a/doc/device-tree/ibm,opal/led.txt +++ b/doc/device-tree/ibm,opal/led.txt @@ -12,7 +12,6 @@ leds { U78C9.001.RST0027-P1-C1 { led-types = "identify", "fault"; - led-loc = "descendent"; phandle = <0x1000006f>; linux,phandle = <0x1000006f>; }; @@ -30,7 +29,5 @@ The properties under each node: led-types : Supported indicators (attention/identify/fault). - led-loc : enclosure/descendent(FRU) location code. - These LEDs can be accessed through OPAL_LEDS_{GET/SET}_INDICATOR interfaces. Refer to doc/opal-api/opal-led-get-set-114-115.txt for interface details. diff --git a/hw/fsp/fsp-leds.c b/hw/fsp/fsp-leds.c index 877aca1a..52d6c90d 100644 --- a/hw/fsp/fsp-leds.c +++ b/hw/fsp/fsp-leds.c @@ -1558,13 +1558,6 @@ void create_led_device_nodes(void) else dt_add_property_strings(cled, DT_PROPERTY_LED_TYPES, LED_TYPE_IDENTIFY); - - if (is_enclosure_led(led->loc_code)) - dt_add_property_strings(cled, DT_PROPERTY_LED_LOCATION, - LED_LOC_ENCLOSURE); - else - dt_add_property_strings(cled, DT_PROPERTY_LED_LOCATION, - LED_LOC_DESCENDENT); } } diff --git a/include/fsp-leds.h b/include/fsp-leds.h index d22d0222..577e719b 100644 --- a/include/fsp-leds.h +++ b/include/fsp-leds.h @@ -161,7 +161,6 @@ struct sai_data { #define DT_PROPERTY_LED_NODE "leds" #define DT_PROPERTY_LED_MODE "led-mode" #define DT_PROPERTY_LED_TYPES "led-types" -#define DT_PROPERTY_LED_LOCATION "led-loc" /* LED Mode */ #define LED_MODE_LIGHT_PATH "lightpath" @@ -172,8 +171,4 @@ struct sai_data { #define LED_TYPE_FAULT "fault" #define LED_TYPE_ATTENTION "attention" -/* LED location */ -#define LED_LOC_ENCLOSURE "enclosure" -#define LED_LOC_DESCENDENT "descendent" - #endif |
