talos-skiboot/libflash/test, branch master

libflash/blocklevel: Make read/write be ECC agnostic for callers

2018-04-10T00:02:11+00:00

The blocklevel abstraction allows for regions of the backing store to be marked as ECC protected so that blocklevel can decode/encode the ECC bytes into the buffer automatically without the caller having to be ECC aware. Unfortunately this abstraction is far from perfect, this is only useful if reads and writes are performed at the start of the ECC region or in some circumstances at an ECC aligned position - which requires the caller be aware of the ECC regions. The problem that has arisen is that the blocklevel abstraction is initialised somewhere but when it is later called the caller is unaware if ECC exists in the region it wants to arbitrarily read and write to. This should not have been a problem since blocklevel knows. Currently misaligned reads will fail ECC checks and misaligned writes will overwrite ECC bytes and the backing store will become corrupted. This patch add the smarts to blocklevel_read() and blocklevel_write() to cope with the problem. Note that ECC can always be bypassed by calling blocklevel_raw_() functions. All this work means that the gard tool can can safely call blocklevel_read() and blocklevel_write() and as long as the blocklevel knows of the presence of ECC then it will deal with all cases. This also commit removes code in the gard tool which compensated for inadequacies no longer present in blocklevel. Signed-off-by: Cyril Bur Tested-by: Pridhiviraj Paidipeddi [stewart: core/flash: Adapt to new libflash ECC API Signed-off-by: Stewart Smith

libflash/blocklevel: Return region start from ecc_protected()

2018-04-09T08:45:23+00:00

Currently all ecc_protected() does is say if a region is ECC protected or not. Knowing a region is ECC protected is one thing but there isn't much that can be done afterwards if this is the only known fact. A lot more can be done if the caller is told where the ECC region begins. Knowing where the ECC region start it allows to caller to align its read/and writes. This allows for more flexibility calling read and write without knowing exactly how the backing store is organised. Signed-off-by: Cyril Bur Signed-off-by: Stewart Smith

libflash/ecc: Add helpers to align a position within an ecc buffer

2018-04-09T08:45:23+00:00

As part of ongoing work to make ECC invisible to higher levels up the stack this function converts a 'position' which should be ECC agnostic to the equivalent position within an ECC region starting at a specified location. Signed-off-by: Cyril Bur Signed-off-by: Stewart Smith

libflash/test: Add tests for mbox-flash

2017-12-18T23:58:32+00:00

A first basic set of tests for mbox-flash. These tests do their testing by stubbing out or otherwise replacing functions not in libflash/mbox-flash.c. The stubbed out version of the function can then be used to emulate a BMC mbox daemon talking to back to the code in mbox-flash and it can ensure that there is some adherence to the protocol and that from a blocklevel api point of view the world appears sane. This makes these tests simple to run and they have been integrated into `make check`. The down side is that these tests rely on duplicated feature incomplete BMC daemon behaviour. Therefore these tests are a strong indicator of broken behaviour but a very unreliable indicator of correctness. Full integration tests with a 'real' BMC daemon are probably beyond the scope of this repository. Signed-off-by: Cyril Bur [stewart: fix TESTS_LOOPS printf] Signed-off-by: Stewart Smith

libflash/test/test-blocklevel: fix memory leak on exit

2017-08-24T02:59:15+00:00

==8304==ERROR: LeakSanitizer: detected memory leaks Direct leak of 4096 byte(s) in 1 object(s) allocated from: #0 0x7f70eda8f850 in malloc (/lib64/libasan.so.4+0xde850) #1 0x408ba0 in main libflash/test/test-blocklevel.c:298 #2 0x7f70ec8e1509 in __libc_start_main (/lib64/libc.so.6+0x20509) Signed-off-by: Stewart Smith

libflash/test/test-flash.c: fix memory leak on exit

2017-08-24T02:59:15+00:00

LeakSanitizer spotted this: Direct leak of 131072 byte(s) in 1 object(s) allocated from: #0 0x7fb99e42b850 in malloc (/lib64/libasan.so.4+0xde850) #1 0x408612 in main libflash/test/test-flash.c:380 #2 0x7fb99d27d509 in __libc_start_main (/lib64/libc.so.6+0x20509) Signed-off-by: Stewart Smith

external/pflash: tests: Move the test-miscprint to pflash tests

2017-08-01T03:58:07+00:00

New code that is very much pflash functionality was added in commit f2c87a3d2f6 "pflash option to retrieve PNOR partition flags". Unfortunately at the time there wasn't an easy way to test pflash. The previous patch adds pflash infrastructure and plumbs it into `make check` nicely. This commit converts the tests originally added to libflash tests. Signed-off-by: Cyril Bur Reviewed-by: Samuel Mendoza-Jonas Signed-off-by: Stewart Smith

libflash: Adding debugging output

2017-08-01T03:57:02+00:00

Also add usage text to pflash. Signed-off-by: Cyril Bur Reviewed-by: Samuel Mendoza-Jonas Signed-off-by: Stewart Smith

pflash option to retrieve PNOR partition flags

2017-07-19T05:49:39+00:00

This commit extends pflash with an option to retrieve and print information for a particular partition, including the content from "pflash -i" and a verbose list of set miscellaneous flags. -i option is also updated to print a short list of flags in addition to the ECC flag, with one character per flag. A test of the new option is included in libflash/test. Signed-off-by: Michael Tritz Reviewed-by: Cyril Bur [stewart@linux.vnet.ibm.com: various test fixes, enable gcov] Signed-off-by: Stewart Smith

libflash: Add tests for blocklevel_smart_erase()

2017-04-07T04:51:34+00:00

Signed-off-by: Cyril Bur Signed-off-by: Stewart Smith