talos-skiboot/libc/stdio/vsnprintf.c, branch master

libc/stdio/vsnprintf.c: add explicit fallthrough

2017-02-02T05:35:42+00:00

silences recent GCC warning Signed-off-by: Stewart Smith

libc : Changes variable data type where return value of strlen() stored from int to size_t

2016-10-11T04:40:30+00:00

Reason of the change as integer value may overflow, and it can give negative value for the length. This patch also changes the data type of variable which is compared with strlen() as the comparison also has to be done on the same level. Signed-off-by: Mukesh Ojha Signed-off-by: Stewart Smith

Fix for typos

2016-06-20T05:08:05+00:00

While reviewing the Debian packaging, codespell found those. Most proposed fixes are based on codespell's default dictionnary. Signed-off-by: Frederic Bonnard Reviewed-by: Mukesh Ojha Signed-off-by: Stewart Smith

opal: Fix buffer overrun in print_* functions.

2015-01-19T06:15:22+00:00

While running HMI tests I saw a massive corruption in OPAL for one of the HMI test that injects TB error. On investigation I found that vsnprintf()->print_itoa() was the culprit. print_itoa function uses tmp array of size 16 to convert unsigned long value to ASCII. But an unsigned value of 0xffffffffffffffff needs atleast 25 characters to print its ASCII representation. This caused an array to overflow resulting into corruption, unpredictable behavior and finally system termination. We could fix this by increasing the size of tmp[] array but that still won't fix this bug completely. While auditing vsnprintf() function I found that it makes use of print_*() functions to write data to buffer. But none of the print_* function have any check on buffer size before writing data to it. Without size check print_*() can easily overrun buffer passed by vprlog()->vsnprintf()->print_format()->print_*() causing massive corruption leading to unpredictable behavior. This patch fixes this bug by modifying print_*() function to check for buffer size to avoid buffer overrun. - Modified print_format(), print_fill() and print_itoa() to take bufsize as argument and added a size check while writing to buffer. - Remove temporary array from print_itoa(), instead write data directly to buffer. - Added two new function print_str_fill() and print_str() to be used as helper routine for '%s' fmt case in print_format() function. These new routines now has a check on buffer size while copying NULL terminated string to buffer. - Added "!bufsize" check in vsnprintf() to avoid buffer overrun while setting NULL character before returning. I ran HMI tests with this patch successfully. I also tested this patch by reducing size of the buffer (in core/console-log.c:vprlog()) from 320 to 50 and booted the lid successfully with no corruption at all. Signed-off-by: Mahesh Salgaonkar Acked-by: Ananth N Mavinakayanahalli Signed-off-by: Stewart Smith

vsnprintf: Change print_itoa to use less stack

2014-11-26T00:22:23+00:00

Remove recursive call in print_itoa to reduce the stack usage. Signed-off-by: Shreyas B. Prabhu Signed-off-by: Stewart Smith

Initial commit of Open Source release

2014-07-02T05:36:20+00:00

Signed-off-by: Benjamin Herrenschmidt