talos-skiboot/core/utils.c, branch master

core/utils: add snprintf_symbol

2018-02-09T00:21:42+00:00

get_symbol is difficult to use. Add snprintf_symbol helper which prints a symbol into a buffer with length, and returns the number of bytes used, similarly to snprintf. Use this in the stack dumping code rather than open-coding it. Signed-off-by: Nicholas Piggin Signed-off-by: Stewart Smith

Add support for new gcc 7 parametrized stack protector

2017-12-21T04:15:36+00:00

This gives us per-cpu guard values as well. For now I just xor a magic constant with the CPU PIR value. Signed-off-by: Benjamin Herrenschmidt Signed-off-by: Stewart Smith

Add fwts annotations for critical errors

2016-06-20T07:18:42+00:00

Signed-off-by: Stewart Smith

Fix two sparse warnings on __stack_chk_guard

2015-11-09T06:35:07+00:00

core/utils.c:25:35: warning: constant 0xdeadf00dbaad300d is so big it is unsigned long core/utils.c:25:15: warning: symbol '__stack_chk_guard' was not declared. Should it be static? Signed-off-by: Stewart Smith

platform: Add platform hook for terminate call

2015-09-09T05:44:15+00:00

Current abort() call works fine on FSP based system. We need different mechanism on BMC based machine. Hence introduce platform hook for terminate call. Signed-off-by: Vasant Hegde Signed-off-by: Stewart Smith

Move FSP specific abort() code to platform layer

2015-09-09T05:43:50+00:00

Presently abort() call sets up HID0, triggers attention and finally calls infinite for loop. FSP takes care of collecting required logs and reboots the system. This sequence is specific to FSP machine and it will not work on BMC based machine. Hence move FSP specific code to hw/fsp/fsp-attn.c. Note that this patch adds new parameter to abort call. Hence replaced _abort() by abort() in exception.c so that we can capture file info as well. Signed-off-by: Vasant Hegde Signed-off-by: Stewart Smith

Disable bust_locks for general calls of abort()

2015-07-06T04:05:46+00:00

Currently bust_locks is set to true whenever abort() is called. This was done for the lock debugging code which calls abort() as its last step. If there is a locking error there is a good chance parts of the console code will be deadlocked (for example if it has a lock on the scom bus). However busting locks can cause problems, especially now that flash data is being read in parallel as this uses the LPC bus. Instead of getting a nice error message showing where the code aborted it is likely the message will go missing, or it will be garbled by the flash data. So instead of always busting locks make it so they're only busted if they're suspected of being broken. Signed-off-by: Alistair Popple Signed-off-by: Stewart Smith

Make abort() update sp attn area (like assert does)

2015-02-11T01:17:21+00:00

Gives better diagnostics in error logs/dumps Signed-off-by: Stewart Smith

Add symbolic backtraces and expose skiboot map to Linux

2014-11-18T08:33:51+00:00

We use a double link technique, doing a first pass with a .o containing a dummy symbol map, then re-linking with a new .o Signed-off-by: Benjamin Herrenschmidt

Rename backtrace.c to stack.c and move stack related bits

2014-11-18T03:43:47+00:00

... from util.c to stack.c Signed-off-by: Benjamin Herrenschmidt