| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
This assumes that if the ATX power is on, the host was previously IPLed
|
|
|
|
| |
This fixes high CPU use on the BMC due to an unneccessarily high IPL status polling rate
|
| |
|
|
|
|
| |
Fix up general handling of IPL observation
|
| |
|
| |
|
|
|
|
|
| |
The I2C bus the FPGA is attached to is even less stable than originally thought
Retry reads and use most commonly returned value as an interim workaround
|
|
|
|
|
| |
The I2C bus on which the FPGA resides is somewhat noisy / high traffic. This leads to frequent i2cget failures.
Retry a failed FPGA register access up to 16 times before aborting.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
| |
This helps reduce issues with the OCCs dropping off the bus
during skiboot initialization
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
driver class
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
The code has an explicit check for a minimum allowed
PGOOD polling interval. Decrease that from 1s to 500ms
as there are new requirements on a specific system
to poll at the 500ms.
Change-Id: If42ecc9244b5e0d8d5b5c17275241f820537d34a
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
|
|
|
|
|
|
|
| |
The device tree file is s2600wf.dts, update to match.
Change-Id: Iefcfefd8b6329aa9afb4b831882e2861a0f6a30a
Signed-off-by: James Feist <james.feist@linux.intel.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Changing the PS redundancy object path from
/org/openbmc/sensors/host/PowerSupplyRedundancy to
/xyz/openbmc_project/sensors/chassis/PowerSupplyRedundancy since
All Witherspoon REST API URIs should being with
xyz/openbmc_project or org/open_power
Change-Id: Ic1360cef2b4939835d47b995a8542aee598bb939
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
|
|
|
|
|
|
|
|
|
| |
GPIO api does not support repeat read(read multi times after one open).
A workaround is close and reopen the device before the second read.
The root cause is that the file descriptor is not moved to beginning of the file, this patch can fix this issue
Change-Id: I40e5602669c9ab6f0dddf5aa77040466cbfa3738
Signed-off-by: Yong Li <yong.b.li@linux.intel.com>
|
|
|
|
|
|
|
| |
Wfp is an Intel platform.
Change-Id: I0991d404f6c5fb8d35d7b524caff0d194d75ee90
Signed-off-by: James Feist <james.feist@linux.intel.com>
|
|
|
|
|
|
|
|
| |
The pci_reset GPIOs are not connected on PASS2 Romulus.
There is no need to toggle the GPIOs.
Change-Id: I78afa4358e2540d72517d5f2ae953f0e6319db1e
Signed-off-by: Lei YU <mine260309@gmail.com>
|
|
|
|
|
| |
Change-Id: Ia4ded0c195204543c3df671ea471610237f5f44b
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added getting the basename for the output file name in
download manager. This is to prevent any security holes
that would let the user out of the FLASH_DOWNLOAD_PATH dir.
(e.g. passing a file name of ../etc/shadow)
Resolves openbmc/openbmc#1898
Change-Id: Ie33fe56599e86c29da4b2eae8ef070f0866d054c
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Nick reported an issue where the BMC became unusable after the host hit
a bug and began "spewing a lot of messages to the console". Save
ourselves some DBus transactions and immediate execution of systemd
transitions by introducing a `chassiskill` command to directly deassert
the the power-up GPIO ourselves. This will immediately terminate the
host and free up resources for the BMC to become responsive. As a bonus,
the PGOOD monitoring will then execute to clean up the resulting
inconsistent BMC/Host state for us.
Change-Id: I106a4202b6544b8e78b04938230a4eeee5f132bb
Requested-by: Nicholas Piggin <npiggin@gmail.com>
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
|
|
|
|
|
|
|
|
|
|
|
| |
If the user passes --wait, try to immediately get the object but wait
until we reach standby before trying again if the first attempt fails.
The correct strategy is probably to look for registration of names on
the bus, but this ghetto approach also works.
Change-Id: I71b6f5d4fcf5841510da6f9877726b875b019d51
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
|
|
|
|
|
| |
Change-Id: I51b4d8a9760e0c73f0c36ff6619a484718db3a4b
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
|
|
|
|
|
| |
Change-Id: I902c6674111a6c1790d08ddf02819dddeede970d
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Verbose output is limited to state change requests at the moment, as
they are the operations that take significant amounts of time. Further,
the verbose output is implemented as following the tail of the journal
until the requested state change either succeeds or fails.
In testing it was observed that the journal output tends to lag the
DBus event that signals the completion of the state transition. As such
the patch adds a tuning parameter defining a further waiting period
beyond the receipt of the completion signal so that the verbose output
looks "reasonable". The default value of the tuning parameter was
roughly chosen to correlate well with the journal output on a
Witherspoon system for the `poweron` command.
Change-Id: I847e2bfeba55d6a3d7d1f7ff1ba1901993c9b505
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The technique to block is to attach a listener for systemd JobRemoved
property change events, change the desired OpenBMC state
management property to trigger the systemd transition, and then run the
gobject dbus mainloop. We terminate the mainloop by invoking quit() in
the callback on the captured mainloop object.
Additionally, the result of the transition (success or failure) is
judged in the callback. We can't obtain the result by returning it, and
as we are using Python 2 we cannot meaningfully mutate captured
variables to expose it. Instead, a variable is created on the callback
function object after it is defined but before the function is invoked,
which is mutated inside the function (which can reference its own
object) when called. The result is retrieved after the mainloop has
terminated and is propagated up the call chain to form the exit status.
Change-Id: Ic19aa604631177abea7580de2357d8c6812ee874
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
|
|
|
|
|
| |
Change-Id: I9d803da8c0ff8862039bb5b7adc07952208820d1
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
|
|
|
|
|
| |
Change-Id: Ibb6d90dbca9c1bffd7b714dc70342b7927ced94e
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
|
|
|
|
|
| |
Change-Id: Id33e3802530aa1bf0cb2af88c16bd94f8bfa219d
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
|
|
|
|
|
| |
Change-Id: I2e310eef36eb7bcea58d1567dcf3efe9a9dbeeb8
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
|
|
|
|
|
|
|
|
|
|
| |
This implements the partner for-loop to the run_one_command() function,
moving the implementation out of main(). Again this is to elevate the
main() implementation to a higher level of abstraction and reduce
cyclomatic complexity.
Change-Id: I0abe5ee026750efd10dafb6f113359f035ba5bd8
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
|
|
|
|
|
|
|
|
|
| |
Move the complexity of the for-loop body implementation away from the
loop itself. This reduces the general cyclomatic complexity a little
and allows for easier consideration of the implementation in isolation.
Change-Id: Id779dec720d3582cf89cd9981bcfd8b101b0d386
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
|
|
|
|
|
| |
Change-Id: I0b1b023aeac7103f0be92201c2475193b0f69e5c
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
|
|
|
|
|
| |
Change-Id: Ie461546c9056829b1b4a081a4031ac91c10e6a42
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
|
|
|
|
|
|
|
|
|
| |
This was prioritised below the built-in value anyway so I suspect it
is an unused feature, especially now that the org.openbmc interfaces
(and the method feature) have gone away.
Change-Id: Icd5ab91b5fc08b0f6cc461390f4ac39f7e9e41cd
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
|
|
|
|
|
| |
Change-Id: Idb1f30dc553cfa95b4669df317a5dbac5dbe8966
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
|
|
|
|
|
|
|
| |
And remove a now-redundant branch.
Change-Id: I92e91cfb307a98cd60a26e5e5d34bf0ddc384d3f
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
|
|
|
|
|
|
|
| |
This changes the format slightly, but not for the worse in my opinion.
Change-Id: Ie9297c22f8c3ceff4fc56ae567dbdbb0f128dd51
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
|
|
|
|
|
| |
Change-Id: I85b74febc33e8f44d9df86718ce6e3ba1d6d6933
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
|
|
|
|
|
| |
Change-Id: I54e04fba2108edce0dbe504ae40f4ae4e073188e
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
|