talos-skeleton/pytools, branch master

pytools: Add completion script for obmcutil

2018-02-26T01:02:52+00:00

Change-Id: Ia248f971e2c8a1ff80f1e6947ef0af283d4ec9ba Signed-off-by: Andrew Jeffery

obmcutil: alias status to state

2018-01-31T03:04:16+00:00

Save users who assume the machine status is available with 'obmcutil status' by aliasing status to state. Change-Id: Icdfa6f62ff6f719386edd892ec80fe29c32087f0 Signed-off-by: Joel Stanley

Spelling fixes

2017-10-26T01:50:47+00:00

Change-Id: Ia4ded0c195204543c3df671ea471610237f5f44b Signed-off-by: Gunnar Mills

pytools: obmcutil: Add `chassiskill` command

2017-10-18T15:03:27+00:00

Nick reported an issue where the BMC became unusable after the host hit a bug and began "spewing a lot of messages to the console". Save ourselves some DBus transactions and immediate execution of systemd transitions by introducing a `chassiskill` command to directly deassert the the power-up GPIO ourselves. This will immediately terminate the host and free up resources for the BMC to become responsive. As a bonus, the PGOOD monitoring will then execute to clean up the resulting inconsistent BMC/Host state for us. Change-Id: I106a4202b6544b8e78b04938230a4eeee5f132bb Requested-by: Nicholas Piggin Signed-off-by: Andrew Jeffery

pytools: obmcutil: Optionally wait for standby before getting objects

2017-10-17T10:47:45+00:00

If the user passes --wait, try to immediately get the object but wait until we reach standby before trying again if the first attempt fails. The correct strategy is probably to look for registration of names on the bus, but this ghetto approach also works. Change-Id: I71b6f5d4fcf5841510da6f9877726b875b019d51 Signed-off-by: Andrew Jeffery

pytools: obmcutil: Use 'in' test rather than dict.has_key()

2017-10-17T06:00:51+00:00

Change-Id: I51b4d8a9760e0c73f0c36ff6619a484718db3a4b Signed-off-by: Andrew Jeffery

pytools: obmcutil: Remove unnecessary parentheses

2017-10-17T06:00:51+00:00

Change-Id: I902c6674111a6c1790d08ddf02819dddeede970d Signed-off-by: Andrew Jeffery

pytools: obmcutil: Implement verbose mode

2017-10-17T06:00:51+00:00

Verbose output is limited to state change requests at the moment, as they are the operations that take significant amounts of time. Further, the verbose output is implemented as following the tail of the journal until the requested state change either succeeds or fails. In testing it was observed that the journal output tends to lag the DBus event that signals the completion of the state transition. As such the patch adds a tuning parameter defining a further waiting period beyond the receipt of the completion signal so that the verbose output looks "reasonable". The default value of the tuning parameter was roughly chosen to correlate well with the journal output on a Witherspoon system for the `poweron` command. Change-Id: I847e2bfeba55d6a3d7d1f7ff1ba1901993c9b505 Signed-off-by: Andrew Jeffery

pytools: obmcutil: Implement blocking behaviour

2017-10-17T06:00:51+00:00

The technique to block is to attach a listener for systemd JobRemoved property change events, change the desired OpenBMC state management property to trigger the systemd transition, and then run the gobject dbus mainloop. We terminate the mainloop by invoking quit() in the callback on the captured mainloop object. Additionally, the result of the transition (success or failure) is judged in the callback. We can't obtain the result by returning it, and as we are using Python 2 we cannot meaningfully mutate captured variables to expose it. Instead, a variable is created on the callback function object after it is defined but before the function is invoked, which is mutated inside the function (which can reference its own object) when called. The result is retrieved after the mainloop has terminated and is propagated up the call chain to form the exit status. Change-Id: Ic19aa604631177abea7580de2357d8c6812ee874 Signed-off-by: Andrew Jeffery

pytools: obmcutil: Use format string for all-props output

2017-10-17T06:00:51+00:00

Change-Id: I9d803da8c0ff8862039bb5b7adc07952208820d1 Signed-off-by: Andrew Jeffery