From c9b485103576156aba29c2d32e6fc9e1f0948304 Mon Sep 17 00:00:00 2001 From: Dan Crowell Date: Fri, 10 Aug 2018 08:57:57 -0500 Subject: Attribute cleanup Added mrwHide to a lot of platInit attributes, this will prevent them from showing up in the ServerWiz tool where the value will be hard to change. Instead these will always rely on the default in the xml or explicit platform code to set. Also removed a bunch of unused tags to clean things up. Change-Id: Id237924d737392368c418cc31d6506f1f5598b98 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/64233 Tested-by: Jenkins Server Reviewed-by: STEPHEN GLANCY Tested-by: HWSV CI Tested-by: PPE CI Tested-by: Hostboot CI Reviewed-by: Joseph J. McGill Reviewed-by: Jennifer A. Stofer Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/66013 Tested-by: FSP CI Jenkins Reviewed-by: Sachin Gupta --- .../xml/attribute_info/nest_attributes.xml | 46 +++--------- .../xml/attribute_info/pervasive_attributes.xml | 82 ++++++---------------- 2 files changed, 30 insertions(+), 98 deletions(-) (limited to 'src') diff --git a/src/import/chips/p9/procedures/xml/attribute_info/nest_attributes.xml b/src/import/chips/p9/procedures/xml/attribute_info/nest_attributes.xml index 0def8829..c031ded7 100644 --- a/src/import/chips/p9/procedures/xml/attribute_info/nest_attributes.xml +++ b/src/import/chips/p9/procedures/xml/attribute_info/nest_attributes.xml @@ -41,8 +41,8 @@ 2133 = 2133, 2400 = 2400 - + freq_pb_mhz @@ -62,7 +62,6 @@ 2000 = 2000, 2400 = 2400 - freq_mca_mhz @@ -76,7 +75,6 @@ uint32 - 4 @@ -90,7 +88,7 @@ uint32 - + @@ -102,7 +100,6 @@ uint32 - @@ -395,6 +392,7 @@ uint8 + @@ -453,6 +451,7 @@ uint8 + @@ -478,6 +477,7 @@ uint8 + @@ -858,9 +858,9 @@ uint8 HB_IPL = 0x1,HB_RUNTIME = 0x2,CACHE_CONTAINED = 0x4,CHIP_CONTAINED = 0x8,NONHB_IPL = 0x10 - + @@ -891,8 +891,8 @@ (excludes system/memory select/group/chip fields) uint64 - + @@ -908,8 +908,8 @@ (excludes system/memory select/group/chip fields) uint64 - + @@ -941,7 +941,7 @@ FLIPPED = 0x1 - + @@ -956,7 +956,6 @@ uint64 8 - @@ -972,7 +971,6 @@ uint64 8 - @@ -988,7 +986,6 @@ uint64 4 - @@ -1004,7 +1001,6 @@ uint64 4 - @@ -1025,8 +1021,6 @@ uint8 - - @@ -1043,8 +1037,6 @@ uint8 - - 128_B = 0x00, 256_B = 0x01, @@ -1075,8 +1067,6 @@ uint8 - - 8 @@ -1112,8 +1102,6 @@ uint32 16,21 - - @@ -1127,8 +1115,6 @@ uint8 - - @@ -1162,7 +1148,6 @@ uint64 - @@ -1193,7 +1178,6 @@ - @@ -1210,7 +1194,6 @@ uint64 24 - @@ -1242,7 +1225,6 @@ 24 - @@ -1254,7 +1236,6 @@ uint64 - @@ -1285,7 +1266,6 @@ - @@ -1301,6 +1281,7 @@ + @@ -1327,7 +1308,6 @@ uint64 - @@ -1358,7 +1338,6 @@ - @@ -1373,7 +1352,6 @@ uint64 8 - @@ -1389,7 +1367,6 @@ uint64 8 - @@ -1405,7 +1382,6 @@ uint64 4 - @@ -1421,7 +1397,6 @@ uint64 4 - @@ -1438,7 +1413,6 @@ uint8 8 - diff --git a/src/import/chips/p9/procedures/xml/attribute_info/pervasive_attributes.xml b/src/import/chips/p9/procedures/xml/attribute_info/pervasive_attributes.xml index f76301e7..d8a6a717 100755 --- a/src/import/chips/p9/procedures/xml/attribute_info/pervasive_attributes.xml +++ b/src/import/chips/p9/procedures/xml/attribute_info/pervasive_attributes.xml @@ -71,7 +71,6 @@ TARGET_TYPE_PROC_CHIP Ref clock I2C bus divider consumed by code running out of OTPROM uint16 - @@ -80,8 +79,8 @@ TARGET_TYPE_PROC_CHIP Capturing EQ Gard value uint8 - + @@ -89,8 +88,8 @@ TARGET_TYPE_PROC_CHIP Capturing EC Gard Value uint32 - + @@ -99,8 +98,8 @@ Indicates istep IPL uint8 NON_IPL = 0x0,IPL = 0x1 - + @@ -109,8 +108,8 @@ Indicates that SBE should go directly to runtime functionality uint8 FALSE = 0x0,TRUE = 0x1 - + @@ -119,8 +118,8 @@ Indicates whether we are connected to FSP or not uint8 FSP_LESS = 0x0,FSP = 0x1 - + @@ -129,8 +128,8 @@ Indicates whether SBE should collect FFDC uint8 FALSE = 0x0,TRUE = 0x1 - + @@ -140,8 +139,8 @@ chipOp failure response uint8 FALSE = 0x0,TRUE = 0x1 - + @@ -149,7 +148,6 @@ TARGET_TYPE_SYSTEM Select Nest I2C and pll setting from one of the supported frequencies uint8 - @@ -158,7 +156,6 @@ TARGET_TYPE_PROC_CHIP Select Filter PLL bucket uint8 - @@ -172,7 +169,6 @@ If zero, VPD MK content will set ATTR_FILTER_PLL_BUCKET. uint8 - @@ -196,7 +192,6 @@ TARGET_TYPE_PROC_CHIP Select OBUS0 pll setting from one of the supported frequencies uint8 - @@ -205,7 +200,6 @@ TARGET_TYPE_PROC_CHIP Select OBUS1 pll setting from one of the supported frequencies uint8 - @@ -214,7 +208,6 @@ TARGET_TYPE_PROC_CHIP Select OBUS2 pll setting from one of the supported frequencies uint8 - @@ -223,7 +216,6 @@ TARGET_TYPE_PROC_CHIP Select OBUS3 pll setting from one of the supported frequencies uint8 - @@ -241,7 +233,6 @@ As an example: 3000MHz / (133MHz/8) = 3000 / 16.667 = ~180 => 0xB4 uint16 - @@ -252,8 +243,8 @@ HWPs uint8 RL0 = 0x0,RL1 = 0x1,RL2 = 0x2,RL3 = 0x3,RL4 = 0x4, RL5 = 0x5 - + @@ -263,8 +254,9 @@ This flag is only applicable when security is disabled. uint8 FALSE = 0x0,TRUE = 0x1 - + FALSE + @@ -272,8 +264,8 @@ TARGET_TYPE_PROC_CHIP Set with Primary SEEPROM uint8 - + @@ -281,8 +273,8 @@ TARGET_TYPE_SYSTEM Switch to using a flag to indicate SEEPROM side SBE uint32 - + @@ -290,9 +282,8 @@ TARGET_TYPE_PROC_CHIP EQ boot frequency uint32 - - + 2400 @@ -300,7 +291,6 @@ TARGET_TYPE_PROC_CHIP FIXME - NEEDS DESCRIPTION uint8 - @@ -316,7 +306,6 @@ TARGET_TYPE_PROC_CHIP FIXME - NEEDS DESCRIPTION uint8 - @@ -337,7 +326,6 @@ TARGET_TYPE_PROC_CHIP I2C Bus speed based on nest freq, ref clock uint8 - @@ -346,7 +334,6 @@ TARGET_TYPE_PROC_CHIP FIXME - NEEDS DESCRIPTION uint8 - @@ -355,7 +342,6 @@ TARGET_TYPE_PROC_CHIP FIXME - NEEDS DESCRIPTION uint8 - @@ -364,7 +350,6 @@ TARGET_TYPE_PROC_CHIP FIXME - NEEDS DESCRIPTION uint8 - @@ -373,7 +358,6 @@ TARGET_TYPE_PROC_CHIP MC mesh to use Nest mesh or not uint8 - IN_SYNC = 1, NOT_IN_SYNC = 0 @@ -395,7 +379,6 @@ TARGET_TYPE_PROC_CHIP Ring image for pb_bndy_dmipll ring creator: platform firmware notes: uint8 - @@ -404,7 +387,6 @@ TARGET_TYPE_PROC_CHIP Ring image for pb_bndy_dmipll ring for DC cal creator: platform firmware notes: uint8 - @@ -413,7 +395,6 @@ TARGET_TYPE_PROC_CHIP Ring image for perv_bndy_pll ring containing filter plls and xb_pll,nest_pll creator: platform firmware notes: uint8 - @@ -423,7 +404,6 @@ Indicates if SBE on this chip is serving as hosboot drawer master uint8 FALSE = 0x0,TRUE = 0x1 - @@ -446,7 +426,6 @@ TARGET_TYPE_PROC_CHIP FIXME - NEEDS DESCRIPTION uint8 - @@ -455,7 +434,6 @@ TARGET_TYPE_PROC_CHIP FIXME - NEEDS DESCRIPTION uint8 - @@ -464,7 +442,6 @@ TARGET_TYPE_PROC_CHIP FIXME - NEEDS DESCRIPTION uint8 - @@ -473,7 +450,6 @@ TARGET_TYPE_PROC_CHIP FIXME - NEEDS DESCRIPTION uint8 - @@ -482,7 +458,6 @@ TARGET_TYPE_PROC_CHIP FIXME - NEEDS DESCRIPTION uint8 - @@ -491,7 +466,6 @@ TARGET_TYPE_PROC_CHIP FIXME - NEEDS DESCRIPTION uint8 - @@ -502,8 +476,8 @@ EX chiplets having good cores even if only a single EX chiplet mode is executed. uint8 - + @@ -512,7 +486,6 @@ Indicates the master boot core chiplet selected by p9_sbe_select_ex. uint8 - @@ -523,7 +496,6 @@ by p9_sbe_select_ex. uint8 - @@ -568,8 +540,7 @@ 0b01 Half speed. uint8 - - + @@ -577,8 +548,7 @@ TARGET_TYPE_SYSTEM Pibmem repair attribute 0 uint64 - - + @@ -586,8 +556,7 @@ TARGET_TYPE_SYSTEM Pibmem repair attribute 1 uint64 - - + @@ -595,8 +564,7 @@ TARGET_TYPE_SYSTEM Pibmem repair attribute 2 uint64 - - + @@ -654,7 +622,6 @@ uint8 - @@ -664,7 +631,6 @@ uint8 - @@ -674,7 +640,6 @@ Functional Target is scommable uint8 - @@ -683,6 +648,7 @@ System Configurtion information - 1 indicates a chip present uint64 + @@ -694,7 +660,6 @@ NONE = 0, FIFTY_OHM = 1 uint8 - @@ -706,7 +671,6 @@ NONE = 0, FIFTY_OHM = 1, ONE_HUNDRED_OHM = 3 uint8 - @@ -746,7 +710,6 @@ TARGET_TYPE_PROC_CHIP Control NDL training:meshctrl setup uint8 - @@ -768,7 +731,6 @@ To allow skew function to be enabled/disabled. uint8 FALSE = 0x0,TRUE = 0x1 - @@ -780,7 +742,6 @@ To allow dcadj function to be enabled/disabled. uint8 FALSE = 0x0,TRUE = 0x1 - @@ -790,7 +751,6 @@ TARGET_TYPE_SYSTEM MC pll bucket selection in async mode for Cumulus uint8 - @@ -802,8 +762,8 @@ we are going to use another proc's memory to boot. The attribute will be set to the chip and group ID of which proc we want to use. uint8 - + @@ -814,7 +774,6 @@ This attribute saves the original value. uint64 - @@ -825,7 +784,6 @@ This attribute saves the original value. uint64 - -- cgit v1.2.1