From 7ebc5456f9cd6efe03d9d17139f2f1a4aa3c5f77 Mon Sep 17 00:00:00 2001
From: Claus Michael Olsen <cmolsen@us.ibm.com>
Date: Sat, 3 Sep 2016 10:29:30 -0500
Subject: xip_customize: Updated mailbox attribute support.

Removed all *_VALID from pervasive_attributes.xml.
Removed ATTR_DPLL_FILTER_BYPASS and ATTR_NEST_MEM_X_O_PCIE_FILTER_BYPASS
Added ATTR_IS_MPIPL back into p9_sbe_attributes.xml.
Initialized ATTR_PG to 0x0000FFFF in sbe_attributes.xml.
Added p9_xip_customize_attributes.xml.

Change-Id: Idbe457f9e79ca084e91d02b43c6880e9c4279858
CMVC-Prereq: 1006768
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/29215
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Reviewed-by: Martin Gloff <mgloff@us.ibm.com>
Reviewed-by: Matt K. Light <mklight@us.ibm.com>
Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/29216
Reviewed-by: Hostboot Team <hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
---
 .../xml/attribute_info/p9_sbe_attributes.xml       | 264 +++++++++------------
 .../xml/attribute_info/pervasive_attributes.xml    | 119 ----------
 2 files changed, 117 insertions(+), 266 deletions(-)

(limited to 'src')

diff --git a/src/import/chips/p9/procedures/xml/attribute_info/p9_sbe_attributes.xml b/src/import/chips/p9/procedures/xml/attribute_info/p9_sbe_attributes.xml
index 345b4a06..f38be59b 100644
--- a/src/import/chips/p9/procedures/xml/attribute_info/p9_sbe_attributes.xml
+++ b/src/import/chips/p9/procedures/xml/attribute_info/p9_sbe_attributes.xml
@@ -41,74 +41,160 @@
     <name>ATTR_PIBMEM_REPAIR2</name>
     <value>0x0000000000000000</value>
   </entry>
+<!-- xip_customize MB attributes - begin-->
   <entry>
     <name>ATTR_I2C_BUS_DIV_REF</name>
     <value>0x0001</value>
   </entry>
   <entry>
-    <name>ATTR_FUNCTIONAL_EQ_EC_VALID</name>
-    <value>0x00</value>
+    <name>ATTR_EQ_GARD</name>
+    <value>0x01</value>
   </entry>
   <entry>
-    <name>ATTR_EQ_GARD</name>
+    <name>ATTR_EC_GARD</name>
     <value>0x01</value>
   </entry>
   <entry>
-     <name>ATTR_EC_GARD</name>
-     <value>0x01</value>
+    <name>ATTR_NEST_PLL_BUCKET</name>
+    <value>0x05</value>
   </entry>
   <entry>
-    <name>ATTR_I2C_BUS_DIV_REF_VALID</name>
-    <value>0x00</value>
+    <name>ATTR_BOOT_FREQ_MULT</name>
+    <value>0x00B4</value>
+  </entry>
+  <entry>
+    <name>ATTR_CLOCK_PLL_MUX</name>
+    <value>0x80010800</value>
   </entry>
   <entry>
-     <name>ATTR_IS_MPIPL</name>
-     <value>0x0</value>
+    <name>ATTR_SS_FILTER_BYPASS</name>
+    <value>0x1</value>
   </entry>
   <entry>
-     <name>ATTR_BOOT_FREQUENCY_VALID</name>
-     <value>0x00</value>
+    <name>ATTR_CP_FILTER_BYPASS</name>
+    <value>0x1</value>
   </entry>
   <entry>
-     <name>ATTR_NEST_PLL_BUCKET</name>
-     <value>0x05</value>
+    <name>ATTR_IO_FILTER_BYPASS</name>
+    <value>0x1</value>
   </entry>
   <entry>
-     <name>ATTR_BOOT_FREQ_MULT</name>
-     <value>0x00B4</value>
+    <name>ATTR_IS_MPIPL</name>
+    <value>0x00</value>
   </entry>
   <entry>
-     <name>ATTR_HWP_CONTROL_FLAGS_VALID</name>
-     <value>0x00</value>
+    <name>ATTR_SYSTEM_IPL_PHASE</name>
+    <value>0x1</value>
   </entry>
   <entry>
-      <name>ATTR_SYSTEM_IPL_PHASE</name>
-      <value>0x1</value>
+    <name>ATTR_SYS_FORCE_ALL_CORES</name>
+    <value>0x00</value>
   </entry>
   <entry>
-      <name>ATTR_RISK_LEVEL</name>
-      <value>0x0</value>
+    <name>ATTR_RISK_LEVEL</name>
+    <value>0x0</value>
   </entry>
   <entry>
-      <name>ATTR_DISABLE_HBBL_VECTORS</name>
-      <value>0x1</value>
+    <name>ATTR_DISABLE_HBBL_VECTORS</name>
+    <value>0x1</value>
   </entry>
   <entry>
-      <name>ATTR_CHIP_SELECTION_VALID</name>
-      <value>0x0</value>
+    <name>ATTR_MC_SYNC_MODE</name>
+    <value>0x01</value>
   </entry>
   <entry>
-      <name>ATTR_CHIP_SELECTION</name>
-      <value>0x1</value>
+    <name>ATTR_PROC_SBE_MASTER_CHIP</name>
+    <value>0x01</value>
+  </entry>
+  <entry>
+    <name>ATTR_PROC_FABRIC_GROUP_ID</name>
+    <value>0x00</value>
+  </entry>
+  <entry>
+    <name>ATTR_PROC_FABRIC_CHIP_ID</name>
+    <value>0x00</value>
   </entry>
   <entry>
-     <name>ATTR_NODE_POS</name>
-     <value>0x01</value>
+    <name>ATTR_DPLL_BYPASS</name>
+    <value>0x0</value>
   </entry>
   <entry>
-     <name>ATTR_CHIP_POS</name>
-     <value>0x01</value>
+    <name>ATTR_NEST_MEM_X_O_PCI_BYPASS</name>
+    <value>0x0</value>
   </entry>
+  <entry>
+      <!-- The values here are per pervasive chiplet in the order of the chiplet
+      numbers Bit 3 (in the 16-bit representation) is used to indicate
+      partial good. If this bit is 1, the region is bad, else it is good.
+      Bits 0,1,2 are don't care. For nimbus, pervasive chiplets 10 and 11 are
+      not used (OB1 and OB2), therefore the value for them is 0xFFFF -->
+            <name>ATTR_PG</name>
+            <value>0xFFFF</value> <!-- Unused -->
+            <value>0xE07D</value> <!-- PERV -->
+            <value>0xE03F</value> <!-- N0 -->
+            <value>0xE03F</value> <!-- N1 -->
+            <value>0xE03F</value> <!-- N2 -->
+            <value>0xE01F</value> <!-- N3 -->
+            <value>0xE44D</value> <!-- XB -->
+            <value>0xE0FD</value> <!-- MC01 -->
+            <value>0xE0FD</value> <!-- MC23 -->
+            <value>0xE1FD</value> <!-- OB0 -->
+            <value>0xFFFF</value> <!-- OB1 -->
+            <value>0xFFFF</value> <!-- OB2 -->
+            <value>0xE1FD</value> <!-- OB3 -->
+            <value>0xE1FD</value> <!-- PCI0 -->
+            <value>0xE0FD</value> <!-- PCI1 -->
+            <value>0xE07D</value> <!-- PCI2 -->
+            <value>0xE001</value> <!-- EP0 -->
+            <value>0xE001</value> <!-- EP1 -->
+            <value>0xE001</value> <!-- EP2 -->
+            <value>0xE288</value> <!-- EP3 -->
+            <value>0xE001</value> <!-- EP4 -->
+            <value>0xE001</value> <!-- EP5 -->
+            <value>0xFFFF</value> <!-- Unused -->
+            <value>0xFFFF</value> <!-- Unused -->
+            <value>0xFFFF</value> <!-- Unused -->
+            <value>0xFFFF</value> <!-- Unused -->
+            <value>0xFFFF</value> <!-- Unused -->
+            <value>0xFFFF</value> <!-- Unused -->
+            <value>0xFFFF</value> <!-- Unused -->
+            <value>0xFFFF</value> <!-- Unused -->
+            <value>0xFFFF</value> <!-- Unused -->
+            <value>0xFFFF</value> <!-- Unused -->
+            <value>0xE1FF</value> <!-- EC00 -->
+            <value>0xE1FF</value> <!-- EC01 -->
+            <value>0xE1FF</value> <!-- EC02 -->
+            <value>0xE1FF</value> <!-- EC03 -->
+            <value>0xE1FF</value> <!-- EC04 -->
+            <value>0xE1FF</value> <!-- EC05 -->
+            <value>0xE1FF</value> <!-- EC06 -->
+            <value>0xE1FF</value> <!-- EC07 -->
+            <value>0xE1FF</value> <!-- EC08 -->
+            <value>0xE1FF</value> <!-- EC09 -->
+            <value>0xE1FF</value> <!-- EC10 -->
+            <value>0xE1FF</value> <!-- EC11 -->
+            <value>0xE1FF</value> <!-- EC12 -->
+            <value>0xE1FF</value> <!-- EC13 -->
+            <value>0xE1FF</value> <!-- EC14 -->
+            <value>0xE1FF</value> <!-- EC15 -->
+            <value>0xE1FF</value> <!-- EC16 -->
+            <value>0xE1FF</value> <!-- EC17 -->
+            <value>0xE1FF</value> <!-- EC18 -->
+            <value>0xE1FF</value> <!-- EC19 -->
+            <value>0xE1FF</value> <!-- EC20 -->
+            <value>0xE1FF</value> <!-- EC21 -->
+            <value>0xE1FF</value> <!-- EC22 -->
+            <value>0xE1FF</value> <!-- EC23 -->
+            <value>0xFFFF</value> <!-- Unused -->
+            <value>0xFFFF</value> <!-- Unused -->
+            <value>0xFFFF</value> <!-- Unused -->
+            <value>0xFFFF</value> <!-- Unused -->
+            <value>0xFFFF</value> <!-- Unused -->
+            <value>0xFFFF</value> <!-- Unused -->
+            <value>0xFFFF</value> <!-- Unused -->
+            <value>0xFFFF</value> <!-- Unused -->
+  </entry>
+<!-- xip_customize MB attributes - end-->
   <entry>
     <name>ATTR_SCRATCH_UINT8_1</name>
     <value>0x8</value>
@@ -275,10 +361,6 @@
       <name>ATTR_BACKUP_SEEPROM_SELECT</name>
       <value>0x0</value>
   </entry>
-  <entry>
-       <name>ATTR_MC_SYNC_MODE</name>
-       <value>0x01</value>
-  </entry>
   <entry>
          <name>ATTR_BOOT_FLAGS</name>
          <value>0x80000000</value>
@@ -295,78 +377,6 @@
            <name>ATTR_VDD_BOOT_VOLTAGE</name>
            <value>0x0</value>
   </entry>
-  <entry>
-      <!-- The values here are per pervasive chiplet in the order of the chiplet
-      numbers Bit 3 (in the 16-bit representation) is used to indicate
-      partial good. If this bit is 1, the region is bad, else it is good.
-      Bits 0,1,2 are don't care. For nimbus, pervasive chiplets 10 and 11 are
-      not used (OB1 and OB2), therefore the value for them is 0xFFFF -->
-            <name>ATTR_PG</name>
-            <value>0xFFFF</value> <!-- Unused -->
-            <value>0xE07D</value> <!-- PERV -->
-            <value>0xE03F</value> <!-- N0 -->
-            <value>0xE03F</value> <!-- N1 -->
-            <value>0xE03F</value> <!-- N2 -->
-            <value>0xE01F</value> <!-- N3 -->
-            <value>0xE00D</value> <!-- XB -->
-            <value>0xE0FD</value> <!-- MC01 -->
-            <value>0xE0FD</value> <!-- MC23 -->
-            <value>0xE1FD</value> <!-- OB0 -->
-            <value>0xFFFF</value> <!-- OB1 -->
-            <value>0xFFFF</value> <!-- OB2 -->
-            <value>0xE1FD</value> <!-- OB3 -->
-            <value>0xE1FD</value> <!-- PCI0 -->
-            <value>0xE0FD</value> <!-- PCI1 -->
-            <value>0xE07D</value> <!-- PCI2 -->
-            <value>0xE001</value> <!-- EP0 -->
-            <value>0xE001</value> <!-- EP1 -->
-            <value>0xE001</value> <!-- EP2 -->
-            <value>0xE288</value> <!-- EP3 -->
-            <value>0xE001</value> <!-- EP4 -->
-            <value>0xE001</value> <!-- EP5 -->
-            <value>0xFFFF</value> <!-- Unused -->
-            <value>0xFFFF</value> <!-- Unused -->
-            <value>0xFFFF</value> <!-- Unused -->
-            <value>0xFFFF</value> <!-- Unused -->
-            <value>0xFFFF</value> <!-- Unused -->
-            <value>0xFFFF</value> <!-- Unused -->
-            <value>0xFFFF</value> <!-- Unused -->
-            <value>0xFFFF</value> <!-- Unused -->
-            <value>0xFFFF</value> <!-- Unused -->
-            <value>0xFFFF</value> <!-- Unused -->
-            <value>0xE1FF</value> <!-- EC00 -->
-            <value>0xE1FF</value> <!-- EC01 -->
-            <value>0xE1FF</value> <!-- EC02 -->
-            <value>0xE1FF</value> <!-- EC03 -->
-            <value>0xE1FF</value> <!-- EC04 -->
-            <value>0xE1FF</value> <!-- EC05 -->
-            <value>0xE1FF</value> <!-- EC06 -->
-            <value>0xE1FF</value> <!-- EC07 -->
-            <value>0xE1FF</value> <!-- EC08 -->
-            <value>0xE1FF</value> <!-- EC09 -->
-            <value>0xE1FF</value> <!-- EC10 -->
-            <value>0xE1FF</value> <!-- EC11 -->
-            <value>0xE1FF</value> <!-- EC12 -->
-            <value>0xE1FF</value> <!-- EC13 -->
-            <value>0xE1FF</value> <!-- EC14 -->
-            <value>0xE1FF</value> <!-- EC15 -->
-            <value>0xE1FF</value> <!-- EC16 -->
-            <value>0xE1FF</value> <!-- EC17 -->
-            <value>0xE1FF</value> <!-- EC18 -->
-            <value>0xE1FF</value> <!-- EC19 -->
-            <value>0xE1FF</value> <!-- EC20 -->
-            <value>0xE1FF</value> <!-- EC21 -->
-            <value>0xE1FF</value> <!-- EC22 -->
-            <value>0xE1FF</value> <!-- EC23 -->
-            <value>0xFFFF</value> <!-- Unused -->
-            <value>0xFFFF</value> <!-- Unused -->
-            <value>0xFFFF</value> <!-- Unused -->
-            <value>0xFFFF</value> <!-- Unused -->
-            <value>0xFFFF</value> <!-- Unused -->
-            <value>0xFFFF</value> <!-- Unused -->
-            <value>0xFFFF</value> <!-- Unused -->
-            <value>0xFFFF</value> <!-- Unused -->
-  </entry>
   <entry>
            <name>ATTR_ADU_XSCOM_BAR_BASE_ADDR</name>
            <value>0x000603FC00000000</value>
@@ -379,22 +389,10 @@
          <name>ATTR_SUN_ID</name>
          <value>0x01</value>
   </entry>
-  <entry>
-         <name>ATTR_PROC_SBE_MASTER_CHIP</name>
-         <value>0x01</value>
-  </entry>
   <entry>
           <name>ATTR_PROC_FABRIC_SYSTEM_ID</name>
           <value>0x00</value>
   </entry>
-  <entry>
-          <name>ATTR_PROC_FABRIC_GROUP_ID</name>
-          <value>0x00</value>
-  </entry>
-  <entry>
-          <name>ATTR_PROC_FABRIC_CHIP_ID</name>
-          <value>0x00</value>
-  </entry>
   <entry>
           <name>ATTR_PROC_FABRIC_ADDR_BAR_MODE</name>
           <value>0x01</value>
@@ -411,10 +409,6 @@
            <name>ATTR_HOSTBOOT_HRMOR_OFFSET</name>
            <value>0x8000000</value>
   </entry>
-  <entry>
-           <name>ATTR_SYS_FORCE_ALL_CORES</name>
-           <value>0x00</value>
-  </entry>
   <entry>
            <name>ATTR_MASTER_CORE</name>
   </entry>
@@ -439,10 +433,6 @@
            <value>0x48000000</value>
   </entry>
   <entry>
-           <name>ATTR_CLOCK_PLL_MUX</name>
-           <value>0x80010800</value>
-  </entry>
-   <entry>
            <name>ATTR_CLOCK_PLL_MUX0</name>
            <value>0x3</value>
   </entry>
@@ -489,26 +479,6 @@
            <name>ATTR_RUNN_MODE</name>
            <value>0x0</value>
   </entry>
-  <entry>
-           <name>ATTR_SS_FILTER_BYPASS</name>
-           <value>0x1</value>
-  </entry>
-  <entry>
-           <name>ATTR_CP_FILTER_BYPASS</name>
-           <value>0x1</value>
-  </entry>
-  <entry>
-           <name>ATTR_IO_FILTER_BYPASS</name>
-           <value>0x1</value>
-  </entry>
-  <entry>
-           <name>ATTR_DPLL_BYPASS</name>
-           <value>0x0</value>
-  </entry>
-  <entry>
-           <name>ATTR_NEST_MEM_X_O_PCI_BYPASS</name>
-           <value>0x0</value>
-  </entry>
   <entry>
            <name>ATTR_VDM_ENABLE</name>
            <value>0x0</value>
diff --git a/src/import/chips/p9/procedures/xml/attribute_info/pervasive_attributes.xml b/src/import/chips/p9/procedures/xml/attribute_info/pervasive_attributes.xml
index a47555d4..198650d2 100644
--- a/src/import/chips/p9/procedures/xml/attribute_info/pervasive_attributes.xml
+++ b/src/import/chips/p9/procedures/xml/attribute_info/pervasive_attributes.xml
@@ -58,17 +58,6 @@
   <writeable/>
 </attribute>
 
-<attribute>
-  <id>ATTR_FUNCTIONAL_EQ_EC_VALID</id>
-  <targetType>TARGET_TYPE_PROC_CHIP</targetType>
-  <description>Indicates the validitiy of FW functional EQ/EQ register</description>
-  <valueType>uint8</valueType>
-  <enum>FALSE = 0x0,TRUE = 0x1</enum>
-  <persistRuntime/>
-  <platInit/>
-  <writeable/>
-</attribute>
-
 <attribute>
   <id>ATTR_EQ_GARD</id>
   <targetType>TARGET_TYPE_PROC_CHIP</targetType>
@@ -89,28 +78,6 @@
   <writeable/>
 </attribute>
 
-<attribute>
-  <id>ATTR_I2C_BUS_DIV_REF_VALID</id>
-  <targetType>TARGET_TYPE_PROC_CHIP</targetType>
-  <description>Indicates the validity of ref clock I2C bus divider consumed by
-      code running out of OTPROM</description>
-  <valueType>uint8</valueType>
-  <enum>FALSE = 0x0,TRUE = 0x1</enum>
-  <persistRuntime/>
-  <platInit/>
-</attribute>
-
-<attribute>
-  <id>ATTR_FW_MODE_FLAGS_VALID</id>
-  <targetType>TARGET_TYPE_PROC_CHIP</targetType>
-  <description>Indicates the validity of FW flags. Ex: ISTEP_MODE,
-      SBE_RUNTIME_MODE, MPIPL_MODE, SP_MODE, SBE_FFDC_ENABLE</description>
-  <valueType>uint8</valueType>
-  <enum>FALSE = 0x0,TRUE = 0x1</enum>
-  <persistRuntime/>
-  <platInit/>
-</attribute>
-
 <attribute>
   <id>ATTR_ISTEP_MODE</id>
   <targetType>TARGET_TYPE_PROC_CHIP</targetType>
@@ -162,17 +129,6 @@
   <platInit/>
 </attribute>
 
-<attribute>
-  <id>ATTR_BOOT_FREQUENCY_VALID</id>
-  <targetType>TARGET_TYPE_PROC_CHIP</targetType>
-  <description>Indicates if BOOT_FREQ_MULT and NEST_PLL_BUCKET
-      are valid</description>
-  <valueType>uint8</valueType>
-  <enum>FALSE = 0x0,TRUE = 0x1</enum>
-  <persistRuntime/>
-  <platInit/>
-</attribute>
-
 <attribute>
   <id>ATTR_NEST_PLL_BUCKET</id>
   <targetType>TARGET_TYPE_SYSTEM</targetType>
@@ -202,17 +158,6 @@
   <writeable/>
 </attribute>
 
-<attribute>
-  <id>ATTR_HWP_CONTROL_FLAGS_VALID</id>
-  <targetType>TARGET_TYPE_PROC_CHIP</targetType>
-  <description>Indicates if HWP control flags
-      are valid</description>
-  <valueType>uint8</valueType>
-  <enum>FALSE = 0x0,TRUE = 0x1</enum>
-  <persistRuntime/>
-  <platInit/>
-</attribute>
-
 <attribute>
   <id>ATTR_RISK_LEVEL</id>
   <targetType>TARGET_TYPE_SYSTEM</targetType>
@@ -237,69 +182,6 @@
   <writeable/>
 </attribute>
 
-<attribute>
-  <id>ATTR_CHIP_SELECTION_VALID</id>
-  <targetType>TARGET_TYPE_PROC_CHIP</targetType>
-  <description>Indicates that master/slave, node/chip selection attributes
-  are valid</description>
-  <valueType>uint8</valueType>
-  <enum>FALSE = 0x0,TRUE = 0x1</enum>
-  <persistRuntime/>
-  <platInit/>
-</attribute>
-
-<attribute>
-  <id>ATTR_CHIP_SELECTION</id>
-  <targetType>TARGET_TYPE_PROC_CHIP</targetType>
-  <description>master/slave bit</description>
-  <valueType>uint8</valueType>
-  <enum>MASTER = 0x0,SLAVE = 0x1</enum>
-  <persistRuntime/>
-  <platInit/>
-</attribute>
-
-<attribute>
-  <id>ATTR_NODE_POS</id>
-  <targetType>TARGET_TYPE_PROC_CHIP</targetType>
-  <description>Indicate the node position in FSP based systems (unused in Spless systems)</description>
-  <valueType>uint8</valueType>
-  <persistRuntime/>
-  <platInit/>
-  <writeable/>
-</attribute>
-
-<attribute>
-  <id>ATTR_CHIP_POS</id>
-  <targetType>TARGET_TYPE_PROC_CHIP</targetType>
-  <description>Indicate the chip position</description>
-  <valueType>uint8</valueType>
-  <persistRuntime/>
-  <platInit/>
-  <writeable/>
-</attribute>
-
-<attribute>
-  <id>ATTR_SCRATCH6_VALID</id>
-  <targetType>TARGET_TYPE_PROC_CHIP</targetType>
-  <description>Indicate if scratch reg6 bits are valid</description>
-  <valueType>uint8</valueType>
-  <enum>FALSE = 0x0,TRUE = 0x1</enum>
-  <persistRuntime/>
-  <platInit/>
-  <writeable/>
-</attribute>
-
-<attribute>
-  <id>ATTR_SCRATCH7_VALID</id>
-  <targetType>TARGET_TYPE_PROC_CHIP</targetType>
-  <description>Indicate if scratch reg7 bits are valid</description>
-  <valueType>uint8</valueType>
-  <enum>FALSE = 0x0,TRUE = 0x1</enum>
-  <persistRuntime/>
-  <platInit/>
-  <writeable/>
-</attribute>
-
 <attribute>
   <id>ATTR_BACKUP_SEEPROM_SELECT</id>
   <targetType>TARGET_TYPE_PROC_CHIP</targetType>
@@ -708,7 +590,6 @@
     <writeable/>
 </attribute>
 
-
 <attribute>
   <id>ATTR_TARGET_HAS_POWER</id>
   <targetType>TARGET_TYPE_PERV</targetType>
-- 
cgit v1.2.1