From 00b05338bf315d05eca094eebf61a22b2783d3bc Mon Sep 17 00:00:00 2001 From: Joe McGill Date: Mon, 28 Aug 2017 10:52:36 -0500 Subject: change queryChipEcAndName to return fapi2 ReturnCode Change-Id: I1a7d1d4582cdae0a35fd7066b1da04092dd179ec Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/45235 Reviewed-by: Joachim Fenkes Tested-by: Jenkins Server Tested-by: FSP CI Jenkins Reviewed-by: Sachin Gupta --- src/hwpf/plat_utils.C | 4 +++- src/tools/scripts/ppeParseAttributeInfo.pl | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/hwpf/plat_utils.C b/src/hwpf/plat_utils.C index b67d4b13..bc565f17 100644 --- a/src/hwpf/plat_utils.C +++ b/src/hwpf/plat_utils.C @@ -121,7 +121,7 @@ namespace fapi2 /// /// @brief Queries the ATTR_NAME and ATTR_EC attributes /// - void queryChipEcAndName( + ReturnCode queryChipEcAndName( const Target < fapi2::TARGET_TYPE_PROC_CHIP > & i_target, fapi2::ATTR_NAME_Type& o_chipName, fapi2::ATTR_EC_Type& o_chipEc ) { @@ -129,6 +129,8 @@ namespace fapi2 FAPI_ATTR_GET_PRIVILEGED(fapi2::ATTR_NAME, i_target, o_chipName); FAPI_ATTR_GET_PRIVILEGED(fapi2::ATTR_EC, i_target, o_chipEc); + + return FAPI2_RC_SUCCESS; } }; diff --git a/src/tools/scripts/ppeParseAttributeInfo.pl b/src/tools/scripts/ppeParseAttributeInfo.pl index 75550eb7..56359b4d 100755 --- a/src/tools/scripts/ppeParseAttributeInfo.pl +++ b/src/tools/scripts/ppeParseAttributeInfo.pl @@ -165,7 +165,7 @@ print ECHFILE " operator ReturnCode (){return value;}\n"; print ECHFILE " private:\n"; print ECHFILE " uint32_t value;\n"; print ECHFILE "};\n"; -print ECHFILE "void queryChipEcAndName(\n"; +print ECHFILE "ReturnCode queryChipEcAndName(\n"; print ECHFILE " const Target& i_target,\n"; print ECHFILE " fapi2::ATTR_NAME_Type& , fapi2::ATTR_EC_Type & );\n\n"; print ECHFILE "template\n"; -- cgit v1.2.1