diff options
| author | Martin Peschke <mpeschke@de.ibm.com> | 2016-06-20 15:57:29 +0200 |
|---|---|---|
| committer | Sachin Gupta <sgupta2m@in.ibm.com> | 2016-09-26 03:09:55 -0400 |
| commit | 91074948a8397cb098ce4bf04568768d5c3ae27d (patch) | |
| tree | 974a0e308da07b85497ab865dfff438b3f2009b6 /src | |
| parent | 1d505bc389c2c104b0c0b4a64955a448c0bb0543 (diff) | |
| download | talos-sbe-91074948a8397cb098ce4bf04568768d5c3ae27d.tar.gz talos-sbe-91074948a8397cb098ce4bf04568768d5c3ae27d.zip | |
p9_tor: remove an include dependency
We used to proliferate a dependency to p9_infrastruct_help.H
through p9_tor.H, which is bad. To be precise, it is p9_tor.C
that needs p9_infrastruct_help.H. Other users of
p9_infrastruct_help.H must not rely on that file being included
by some other include, but they should include it directly.
Change-Id: Ibfb9f452b9530f3f13cf81c105d4b48c8e181f65
Original-Change-Id: Id76608e5e5e3006247fb2f26648ec522c84f9c43
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/26037
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com>
Reviewed-by: Richard J. Knight <rjknight@us.ibm.com>
Reviewed-by: Prachi Gupta <pragupta@us.ibm.com>
Reviewed-by: Martin Peschke <mpeschke@de.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/30248
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/import/chips/p9/utils/imageProcs/p9_tor.C | 2 | ||||
| -rw-r--r-- | src/import/chips/p9/utils/imageProcs/p9_tor.H | 1 | ||||
| -rw-r--r-- | src/import/tools/imageProcs/p9_ipl_build.C | 1 |
3 files changed, 2 insertions, 2 deletions
diff --git a/src/import/chips/p9/utils/imageProcs/p9_tor.C b/src/import/chips/p9/utils/imageProcs/p9_tor.C index efa8139e..a051725b 100644 --- a/src/import/chips/p9/utils/imageProcs/p9_tor.C +++ b/src/import/chips/p9/utils/imageProcs/p9_tor.C @@ -39,7 +39,7 @@ // #include "p9_tor.H" #include "p9_xip_image.h" -#include <fapi2.H> +#include "p9_infrastruct_help.H" namespace P9_TOR { diff --git a/src/import/chips/p9/utils/imageProcs/p9_tor.H b/src/import/chips/p9/utils/imageProcs/p9_tor.H index 391f91af..d9840bd7 100644 --- a/src/import/chips/p9/utils/imageProcs/p9_tor.H +++ b/src/import/chips/p9/utils/imageProcs/p9_tor.H @@ -27,7 +27,6 @@ #include "p9_ring_identification.H" #include "p9_ringId.H" -#include "p9_infrastruct_help.H" namespace P9_TOR { diff --git a/src/import/tools/imageProcs/p9_ipl_build.C b/src/import/tools/imageProcs/p9_ipl_build.C index 3e372476..9d4c990f 100644 --- a/src/import/tools/imageProcs/p9_ipl_build.C +++ b/src/import/tools/imageProcs/p9_ipl_build.C @@ -51,6 +51,7 @@ #include "p9_ipl_build.H" #include <p9_xip_image.h> #include <p9_tor.H> +#include <p9_infrastruct_help.H> using namespace P9_TOR; |
