diff options
| author | Martin Peschke <mpeschke@de.ibm.com> | 2016-08-05 15:29:36 +0200 |
|---|---|---|
| committer | Sachin Gupta <sgupta2m@in.ibm.com> | 2016-09-26 03:13:19 -0400 |
| commit | e75753384b43b6892866532d2bab14aa3836aca5 (patch) | |
| tree | 1de8486f12e8978347c07327baf12fe188076bfb /src/import | |
| parent | 0ead201174fd49036369b02daeb76df87d24591f (diff) | |
| download | talos-sbe-e75753384b43b6892866532d2bab14aa3836aca5.tar.gz talos-sbe-e75753384b43b6892866532d2bab14aa3836aca5.zip | |
p9_ringId / p9_ring_identification: cleanup extern declarations
There is whole bunch of extern declarations in p9_ring_identification.H
which refer to stuff that is actually declared in p9_ringId.C.
So the right place for these extern declaration is p9_ringId.H.
Moving these allows to move a couple of structure definitions,
which belong to p9_ringId as well. Besides an unused structure
definition is removed entirely.
Having these things fall into the right places has enabled
cleaning up a few include statements. This makes sure that other
code doesn't pick up stuff that it doesn't need.
Change-Id: I6346d006a783e990e4c6bb5de9632c54279f3974
Original-Change-Id: Ic6e8748b8b56653859d1e146ea44e19b7243fd23
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/27909
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: RANGANATHPRASAD G. BRAHMASAMUDRA <prasadbgr@in.ibm.com>
Reviewed-by: Prachi Gupta <pragupta@us.ibm.com>
Reviewed-by: Martin Peschke <mpeschke@de.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/30259
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com>
Diffstat (limited to 'src/import')
| -rw-r--r-- | src/import/chips/p9/utils/imageProcs/p9_ringId.C | 1 | ||||
| -rw-r--r-- | src/import/chips/p9/utils/imageProcs/p9_tor.H | 1 |
2 files changed, 1 insertions, 1 deletions
diff --git a/src/import/chips/p9/utils/imageProcs/p9_ringId.C b/src/import/chips/p9/utils/imageProcs/p9_ringId.C index 141088f4..e7caed40 100644 --- a/src/import/chips/p9/utils/imageProcs/p9_ringId.C +++ b/src/import/chips/p9/utils/imageProcs/p9_ringId.C @@ -22,6 +22,7 @@ /* permissions and limitations under the License. */ /* */ /* IBM_PROLOG_END_TAG */ + #include "p9_ringId.H" #include "p9_ring_identification.H" #include "p9_tor.H" diff --git a/src/import/chips/p9/utils/imageProcs/p9_tor.H b/src/import/chips/p9/utils/imageProcs/p9_tor.H index 251f6ecb..53d7721a 100644 --- a/src/import/chips/p9/utils/imageProcs/p9_tor.H +++ b/src/import/chips/p9/utils/imageProcs/p9_tor.H @@ -25,7 +25,6 @@ #ifndef _P9_TOR_H_ #define _P9_TOR_H_ -#include "p9_ring_identification.H" #include "p9_ring_id.h" namespace P9_TOR |
