diff options
author | Greg Still <stillgs@us.ibm.com> | 2017-08-25 17:09:56 -0500 |
---|---|---|
committer | Sachin Gupta <sgupta2m@in.ibm.com> | 2017-09-22 11:51:27 -0400 |
commit | d61fd2c3c681f76363a484e810c6c10af87e8a9c (patch) | |
tree | aae83c31dd956ec28312e9875e0c32ab8b15b15e | |
parent | 3c46b699bec294a8023f5709958df62fb7d586df (diff) | |
download | talos-sbe-d61fd2c3c681f76363a484e810c6c10af87e8a9c.tar.gz talos-sbe-d61fd2c3c681f76363a484e810c6c10af87e8a9c.zip |
PM: Move to chip EC based #V validity checking in p9_pstate_parameter_block
- Was always returning SUCCESS which caused p9_hcode_image_build to not
properly terminate (false error logs)
- Added EC feature attribute to skip #V validity checking and thus disabling
pstates for Nimbus < 20 and Cumulus < 11
- Initalized wof io_size to 0.
- Rebased
- Added override attribute ATTR_SYSTEM_POUNDV_VALIDITY_HALT_DISABLE to disable
killing the IPL upon #V validity check failure. Disables Pstates and
continues. This allow the use of parts that don't have good #V for other,
non-Pstate oriented purposes. Marked with new <overrideOnly/> tag.
Change-Id: Ia238af9758ae1fe35d39fa536d73ec41e85f9498
CQ: SW400102
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/45185
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: RANGANATHPRASAD G. BRAHMASAMUDRA <prasadbgr@in.ibm.com>
Reviewed-by: Juan R. Medina <jrmedina@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/46083
Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com>
-rw-r--r-- | src/import/chips/p9/procedures/xml/attribute_info/chip_ec_attributes.xml | 25 | ||||
-rw-r--r-- | src/import/chips/p9/procedures/xml/attribute_info/pm_plat_attributes.xml | 28 |
2 files changed, 52 insertions, 1 deletions
diff --git a/src/import/chips/p9/procedures/xml/attribute_info/chip_ec_attributes.xml b/src/import/chips/p9/procedures/xml/attribute_info/chip_ec_attributes.xml index 78692ec0..4ae4caa6 100644 --- a/src/import/chips/p9/procedures/xml/attribute_info/chip_ec_attributes.xml +++ b/src/import/chips/p9/procedures/xml/attribute_info/chip_ec_attributes.xml @@ -5193,6 +5193,31 @@ </chip> </chipEcFeature> </attribute> + <!-- ********************************************************************* --> + <attribute> + <id>ATTR_CHIP_EC_FEATURE_POUNDV_VALIDATE_DISABLE</id> + <targetType>TARGET_TYPE_PROC_CHIP</targetType> + <description> + Disables the checking of #V validity by p9_pstate_parameter_block. + If not disable, invalid #V will fail to IPL. + </description> + <chipEcFeature> + <chip> + <name>ENUM_ATTR_NAME_NIMBUS</name> + <ec> + <value>0x20</value> + <test>LESS_THAN</test> + </ec> + </chip> + <chip> + <name>ENUM_ATTR_NAME_CUMULUS</name> + <ec> + <value>0x11</value> + <test>LESS_THAN</test> + </ec> + </chip> + </chipEcFeature> + </attribute> <!-- ********************************************************************* --> <attribute> <id>ATTR_CHIP_EC_FEATURE_OBUS_HW419305</id> diff --git a/src/import/chips/p9/procedures/xml/attribute_info/pm_plat_attributes.xml b/src/import/chips/p9/procedures/xml/attribute_info/pm_plat_attributes.xml index ad7c55ea..fb5043c7 100644 --- a/src/import/chips/p9/procedures/xml/attribute_info/pm_plat_attributes.xml +++ b/src/import/chips/p9/procedures/xml/attribute_info/pm_plat_attributes.xml @@ -973,6 +973,32 @@ </attribute> <!-- ********************************************************************* --> <attribute> + <id>ATTR_SYSTEM_POUNDV_VALIDITY_HALT_DISABLE</id> + <targetType>TARGET_TYPE_SYSTEM</targetType> + <description>Disables the validity checking of #V VPD content from causing + IPL failures. + + OFF: Will enable PStates given all validity checks pass. If + validity checks fail, the a failure is log and error reaction + will occur (eg IPL failure) + ON: Will disable #V validity checking of #V from causing IPL + to halt. Validity check failures will cause error logs and + Pstates (including other dependent functions) will be + disabled. + + Producer: Override + + Consumers: p9_pstate_parameter_block + + </description> + <valueType>uint8</valueType> + <enum>OFF=0, ON=1</enum> + <platInit/> + <initToZero/> + <overrideOnly/> + </attribute> + <!-- ********************************************************************* --> + <attribute> <id>ATTR_SYSTEM_WOF_DISABLE</id> <targetType>TARGET_TYPE_SYSTEM</targetType> <description>Disables Work Load Optimized Frequency (WOF) algorithms to @@ -1036,7 +1062,7 @@ THIS IS NOT SUPPORTED AT PRESENT. GA1 SUPPORT IS TBD). </description> <valueType>uint8</valueType> - <enum>FIXED=0, STEPPED=1</enum> + <enum>FIXED=0, CALCULATED=1</enum> <platInit/> <initToZero/> </attribute> |