summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMartin Peschke <mpeschke@de.ibm.com>2016-09-15 16:33:13 +0200
committerSachin Gupta <sgupta2m@in.ibm.com>2016-10-04 07:13:39 -0400
commit9e89ef08ab80466c0eb3873540863f9046c321e1 (patch)
tree0ac90eea1bbb12be01c09d1b7493bd01e609cf05
parentfcf2fc04cfa705d3beb138edfe379ab0c228aad6 (diff)
downloadtalos-sbe-9e89ef08ab80466c0eb3873540863f9046c321e1.tar.gz
talos-sbe-9e89ef08ab80466c0eb3873540863f9046c321e1.zip
P9-XIP: simplify p9_xip_get_scalar()
Removing code duplication Change-Id: I7708a9016c2a8679454c26df87dab350e7443df6 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/29765 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: Richard J. Knight <rjknight@us.ibm.com> Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com> Reviewed-by: Martin Peschke <mpeschke@de.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/29773 Reviewed-by: Hostboot Team <hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
-rw-r--r--src/import/chips/p9/xip/p9_xip_image.c22
1 files changed, 6 insertions, 16 deletions
diff --git a/src/import/chips/p9/xip/p9_xip_image.c b/src/import/chips/p9/xip/p9_xip_image.c
index 6272ec38..bad0ad5f 100644
--- a/src/import/chips/p9/xip/p9_xip_image.c
+++ b/src/import/chips/p9/xip/p9_xip_image.c
@@ -2165,22 +2165,6 @@ p9_xip_get_item(const P9XipItem* i_item, uint64_t* o_data, uint32_t i_index)
}
int
-p9_xip_get_scalar(void* i_image, const char* i_id, uint64_t* o_data)
-{
- int rc;
- P9XipItem item;
-
- rc = p9_xip_find(i_image, i_id, &item);
-
- if (!rc)
- {
- rc = p9_xip_get_item(&item, o_data, 0);
- }
-
- return rc;
-}
-
-int
p9_xip_get_element(void* i_image,
const char* i_id,
const uint32_t i_index,
@@ -2201,6 +2185,12 @@ p9_xip_get_element(void* i_image,
int
+p9_xip_get_scalar(void* i_image, const char* i_id, uint64_t* o_data)
+{
+ return p9_xip_get_element(i_image, i_id, 0, o_data);
+}
+
+int
p9_xip_get_string(void* i_image, const char* i_id, char** o_data)
{
int rc;
OpenPOWER on IntegriCloud