diff options
| author | Joachim Fenkes <fenkes@de.ibm.com> | 2017-04-28 18:12:44 +0200 |
|---|---|---|
| committer | Sachin Gupta <sgupta2m@in.ibm.com> | 2017-06-02 00:43:11 -0400 |
| commit | 3b16dea285753eb526b73227968eb5c6b3a158c2 (patch) | |
| tree | 676704c1bb79f08da7bf1da52bd2e064ea96367d | |
| parent | 2d99c8898c6eb407ff7656af3e9ae9c72729bece (diff) | |
| download | talos-sbe-3b16dea285753eb526b73227968eb5c6b3a158c2.tar.gz talos-sbe-3b16dea285753eb526b73227968eb5c6b3a158c2.zip | |
p9_fastarray: Fix ABIST engines not running to completion
Turns out that having the core region fences raised causes
ABIST_DONE to be on even if the engines aren't really done. This
caused subsequent dumps to return bad data. Fixed.
Change-Id: I5d69511297609ab1a673aee63327977e6007b4e6
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/40076
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Joseph J. McGill <jmcgill@us.ibm.com>
Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com>
Reviewed-by: James N. Klazynski <jklazyns@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/40092
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com>
| -rw-r--r-- | src/import/chips/p9/procedures/hwp/perv/p9_sbe_fastarray_cleanup.C | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/import/chips/p9/procedures/hwp/perv/p9_sbe_fastarray_cleanup.C b/src/import/chips/p9/procedures/hwp/perv/p9_sbe_fastarray_cleanup.C index 4b10a7ee..23c6ccdf 100644 --- a/src/import/chips/p9/procedures/hwp/perv/p9_sbe_fastarray_cleanup.C +++ b/src/import/chips/p9/procedures/hwp/perv/p9_sbe_fastarray_cleanup.C @@ -53,8 +53,8 @@ fapi2::ReturnCode p9_sbe_fastarray_cleanup( { fapi2::buffer<uint64_t> l_buf; - /* Drop vital fence so that we can see the ABIST_DONE signal */ - FAPI_TRY(fapi2::putScom(i_target_chiplet, PERV_CPLT_CTRL1_CLEAR, 0x1000000000000000), "Failed to drop vitl fence"); + /* Drop vital fence and core region fences so that we can see the ABIST_DONE signal */ + FAPI_TRY(fapi2::putScom(i_target_chiplet, PERV_CPLT_CTRL1_CLEAR, 0x1E00000000000000), "Failed to drop region fences"); /* Let ABIST engines run to completion */ { @@ -73,8 +73,8 @@ fapi2::ReturnCode p9_sbe_fastarray_cleanup( } } - /* Raise the vital fence back up */ - FAPI_TRY(fapi2::putScom(i_target_chiplet, PERV_CPLT_CTRL1_OR, 0x1000000000000000), "Failed to raise vitl fence"); + /* Raise the region fences back up */ + FAPI_TRY(fapi2::putScom(i_target_chiplet, PERV_CPLT_CTRL1_OR, 0x1E00000000000000), "Failed to raise region fences"); /* Disable ABIST and clock engines so they can cleanly reset */ l_buf = 0; |
