multiple collectFfdc tags results in dupicate code

    -Updated parser to eliminate multiple calls when there are
     more than on collectFfdc tag in the hwpError section

Change-Id: I04b485d7d232d65d9ba02add03d8ac0901872c7f
RTC:179620
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/45904
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: AMIT J. TENDOLKAR <amit.tendolkar@in.ibm.com>
Reviewed-by: Prem Shanker Jha <premjha2@in.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/45910
Reviewed-by: Hostboot Team <hostboot@us.ibm.com>
Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com>

1 files changed, 6 insertions, 4 deletions

diff --git a/src/import/hwpf/fapi2/tools/parseErrorInfo.pl b/src/import/hwpf/fapi2/tools/parseErrorInfo.pl
index 9b74e26d..06b90d10 100755
--- a/src/import/hwpf/fapi2/tools/parseErrorInfo.pl
+++ b/src/import/hwpf/fapi2/tools/parseErrorInfo.pl
@@ -727,7 +727,7 @@ foreach my $argnum ( 0 .. $#ARGV )
                 @elements[$i] =~ s/^\s+|\s+$//g;
                 addFfdcMethod( \%methods, @elements[$i], $err->{rc}, $ffdc_type, $objNum );
 
-                $collectFfdc .= "@elements[$i]"
+                $collectFfdc .= "@elements[$i]";
 
             }
 
@@ -751,11 +751,13 @@ foreach my $argnum ( 0 .. $#ARGV )
 
             # assign the tempRc with newly added ffdc back to the passed in RC
             $collectFfdcStr .= "\tRC = tempRc; \\\n";
-
-            print EIFILE "\\\n{ \\\n$collectFfdcStr \\\n}";
-
         }    #end collectFfdc tag
 
+        if ( defined $collectFfdcStr )
+        {
+            print EIFILE "\\\n{ \\\n$collectFfdcStr}";
+        }
+
         print EIFILE "\n";
 
         #----------------------------------------------------------------------