From c9c964c8c03c766d94d4798231d6e3db191c57df Mon Sep 17 00:00:00 2001 From: Samuel Mendoza-Jonas Date: Wed, 11 Nov 2015 16:11:41 +1100 Subject: ui/ncurses: Check for NULL in pmenu_item_get_index() Fixes Coverity defect #30476 Signed-off-by: Samuel Mendoza-Jonas --- ui/ncurses/nc-menu.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'ui') diff --git a/ui/ncurses/nc-menu.c b/ui/ncurses/nc-menu.c index 3f09d62..dda7626 100644 --- a/ui/ncurses/nc-menu.c +++ b/ui/ncurses/nc-menu.c @@ -322,9 +322,10 @@ static int pmenu_item_get_index(const struct pmenu_item *item) { unsigned int i; - for (i = 0; i < item->pmenu->item_count; i++) - if (item->pmenu->items[i] == item->nci) - return i; + if (item) + for (i = 0; i < item->pmenu->item_count; i++) + if (item->pmenu->items[i] == item->nci) + return i; pb_log("%s: not found: %p %s\n", __func__, item, (item ? item->nci->name.str : "(null)")); -- cgit v1.2.1