From e25641dc14753cc070ecf50e10809ce3ce8b9ecd Mon Sep 17 00:00:00 2001 From: Samuel Mendoza-Jonas Date: Fri, 18 Dec 2015 14:04:15 +1100 Subject: lib/talloc: Avoid early exit before va_end() Fixes Coverity defect #30486 Signed-off-by: Sam Mendoza-Jonas --- lib/talloc/talloc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'lib/talloc/talloc.c') diff --git a/lib/talloc/talloc.c b/lib/talloc/talloc.c index fa34323..f233541 100644 --- a/lib/talloc/talloc.c +++ b/lib/talloc/talloc.c @@ -1032,13 +1032,15 @@ static char *talloc_vasprintf_append(char *s, const char *fmt, va_list ap) len = vsnprintf(NULL, 0, fmt, ap2); s = talloc_realloc(NULL, s, char, s_len + len+1); - if (!s) return NULL; + if (!s) + goto out; VA_COPY(ap2, ap); vsnprintf(s+s_len, len+1, fmt, ap2); talloc_set_name_const(s, s); +out: va_end(ap2); return s; } -- cgit v1.2.1