summaryrefslogtreecommitdiffstats
path: root/ui/ncurses
diff options
context:
space:
mode:
authorSamuel Mendoza-Jonas <sam.mj@au1.ibm.com>2015-11-11 16:11:41 +1100
committerSamuel Mendoza-Jonas <sam.mj@au1.ibm.com>2015-12-17 14:51:46 +1100
commitc9c964c8c03c766d94d4798231d6e3db191c57df (patch)
tree57a208d5715d641680d5b08e331534cfad067560 /ui/ncurses
parentdf751aad6736c25a3f3088ad626bd28d2ced1991 (diff)
downloadtalos-petitboot-c9c964c8c03c766d94d4798231d6e3db191c57df.tar.gz
talos-petitboot-c9c964c8c03c766d94d4798231d6e3db191c57df.zip
ui/ncurses: Check for NULL in pmenu_item_get_index()
Fixes Coverity defect #30476 Signed-off-by: Samuel Mendoza-Jonas <sam.mj@au1.ibm.com>
Diffstat (limited to 'ui/ncurses')
-rw-r--r--ui/ncurses/nc-menu.c7
1 files changed, 4 insertions, 3 deletions
diff --git a/ui/ncurses/nc-menu.c b/ui/ncurses/nc-menu.c
index 3f09d62..dda7626 100644
--- a/ui/ncurses/nc-menu.c
+++ b/ui/ncurses/nc-menu.c
@@ -322,9 +322,10 @@ static int pmenu_item_get_index(const struct pmenu_item *item)
{
unsigned int i;
- for (i = 0; i < item->pmenu->item_count; i++)
- if (item->pmenu->items[i] == item->nci)
- return i;
+ if (item)
+ for (i = 0; i < item->pmenu->item_count; i++)
+ if (item->pmenu->items[i] == item->nci)
+ return i;
pb_log("%s: not found: %p %s\n", __func__, item,
(item ? item->nci->name.str : "(null)"));
OpenPOWER on IntegriCloud