summaryrefslogtreecommitdiffstats
path: root/lib/talloc/talloc.c
diff options
context:
space:
mode:
authorSamuel Mendoza-Jonas <sam.mj@au1.ibm.com>2015-12-18 14:04:15 +1100
committerSam Mendoza-Jonas <sam@mendozajonas.com>2016-02-09 13:39:34 +1100
commite25641dc14753cc070ecf50e10809ce3ce8b9ecd (patch)
tree9aac354f13b33292f76596f0200447dd43d3aa91 /lib/talloc/talloc.c
parent5f339d4485e450adac994c190bfafb45734bcae9 (diff)
downloadtalos-petitboot-e25641dc14753cc070ecf50e10809ce3ce8b9ecd.tar.gz
talos-petitboot-e25641dc14753cc070ecf50e10809ce3ce8b9ecd.zip
lib/talloc: Avoid early exit before va_end()
Fixes Coverity defect #30486 Signed-off-by: Sam Mendoza-Jonas <sam@mendozajonas.com>
Diffstat (limited to 'lib/talloc/talloc.c')
-rw-r--r--lib/talloc/talloc.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/lib/talloc/talloc.c b/lib/talloc/talloc.c
index fa34323..f233541 100644
--- a/lib/talloc/talloc.c
+++ b/lib/talloc/talloc.c
@@ -1032,13 +1032,15 @@ static char *talloc_vasprintf_append(char *s, const char *fmt, va_list ap)
len = vsnprintf(NULL, 0, fmt, ap2);
s = talloc_realloc(NULL, s, char, s_len + len+1);
- if (!s) return NULL;
+ if (!s)
+ goto out;
VA_COPY(ap2, ap);
vsnprintf(s+s_len, len+1, fmt, ap2);
talloc_set_name_const(s, s);
+out:
va_end(ap2);
return s;
}
OpenPOWER on IntegriCloud