diff options
| author | Jeremy Kerr <jk@ozlabs.org> | 2014-01-21 10:00:49 +0800 |
|---|---|---|
| committer | Jeremy Kerr <jk@ozlabs.org> | 2014-01-21 13:36:01 +0800 |
| commit | 2ad0e66f61e8f8488cff208f8bb7f5127ec9f813 (patch) | |
| tree | aa676b143507346dbde4998bdd38f8e375387cb6 /lib/pb-config | |
| parent | 6acda62401f17924b7004e25d038533e282903a1 (diff) | |
| download | talos-petitboot-2ad0e66f61e8f8488cff208f8bb7f5127ec9f813.tar.gz talos-petitboot-2ad0e66f61e8f8488cff208f8bb7f5127ec9f813.zip | |
lib/process: Add helper for check process clean exit
We have a few incorrect checks for the exit status of a process; this
change adds a helper with the correct WIFEXITED && WEXITSTATUS==0 logic.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Diffstat (limited to 'lib/pb-config')
| -rw-r--r-- | lib/pb-config/storage-powerpc-nvram.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/lib/pb-config/storage-powerpc-nvram.c b/lib/pb-config/storage-powerpc-nvram.c index 42de598..4b4b878 100644 --- a/lib/pb-config/storage-powerpc-nvram.c +++ b/lib/pb-config/storage-powerpc-nvram.c @@ -137,8 +137,7 @@ static int parse_nvram(struct powerpc_nvram_storage *nv) rc = process_run_sync(process); - if (rc || !WIFEXITED(process->exit_status) - || WEXITSTATUS(process->exit_status)) { + if (rc || !process_exit_ok(process)) { fprintf(stderr, "nvram process returned " "non-zero exit status\n"); rc = -1; @@ -183,8 +182,7 @@ static int write_nvram(struct powerpc_nvram_storage *nv) talloc_free(paramstr); - if (rc || !WIFEXITED(process->exit_status) - || WEXITSTATUS(process->exit_status)) { + if (rc || !process_exit_ok(process)) { rc = -1; pb_log("nvram update process returned " "non-zero exit status\n"); |
