diff options
| author | Samuel Mendoza-Jonas <sam.mj@au1.ibm.com> | 2015-11-09 14:45:58 +1100 |
|---|---|---|
| committer | Samuel Mendoza-Jonas <sam.mj@au1.ibm.com> | 2015-12-17 14:51:46 +1100 |
| commit | eea8cf830616dbbd9024b7d704cf0ccf2dac4767 (patch) | |
| tree | a2eae11b0af3de7c71d74d7acac9952b485c6f3e /discover/paths.c | |
| parent | 0dae90626e54e46372c9feddc2f9ac82f046547d (diff) | |
| download | talos-petitboot-eea8cf830616dbbd9024b7d704cf0ccf2dac4767.tar.gz talos-petitboot-eea8cf830616dbbd9024b7d704cf0ccf2dac4767.zip | |
discover: Properly handle return values
Fixes three unchecked return values, and one missing
initialisation.
Fixes Coverity defects #30450, #30451, #30454, and #30483
Signed-off-by: Samuel Mendoza-Jonas <sam.mj@au1.ibm.com>
Diffstat (limited to 'discover/paths.c')
| -rw-r--r-- | discover/paths.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/discover/paths.c b/discover/paths.c index 0d414eb..c25671b 100644 --- a/discover/paths.c +++ b/discover/paths.c @@ -220,15 +220,16 @@ static enum tftp_type check_tftp_type(void *ctx) const char *argv[] = { pb_system_apps.tftp, "-V", NULL }; struct process *process; enum tftp_type type; + int rc; process = process_create(ctx); process->path = pb_system_apps.tftp; process->argv = argv; process->keep_stdout = true; process->add_stderr = true; - process_run_sync(process); + rc = process_run_sync(process); - if (!process->stdout_buf || process->stdout_len == 0) { + if (rc || !process->stdout_buf || process->stdout_len == 0) { pb_log("Can't check TFTP client type!\n"); type = TFTP_TYPE_BROKEN; |
