summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGuilherme G. Piccoli <gpiccoli@linux.vnet.ibm.com>2017-07-11 15:04:05 -0300
committerSamuel Mendoza-Jonas <sam@mendozajonas.com>2017-07-12 14:47:06 +1000
commit3fc71b6422efdeb093ca6693553c0c31758a68d1 (patch)
treead64131e3f9906ffb314f6c8ea271cc10794c8bf
parent135dc3721e847661d32b180d978c8e0def7afc86 (diff)
downloadtalos-petitboot-3fc71b6422efdeb093ca6693553c0c31758a68d1.zip
talos-petitboot-3fc71b6422efdeb093ca6693553c0c31758a68d1.tar.gz
pb-sos: effectively compress the pb-sos file with gzipv1.5.0
Currently the pb-sos tool creates a TAR file with logs, but without compressing it using gzip, for example. Even the output of command says "Compressing...", but in fact no compression is done. This patch uses gzip to effectively compress the logs. It achieves 83% of compression, observed after a simple experiment. Also, makes use of $tarflags variable instead of pass the flags directly in the command call. Signed-off-by: Guilherme G. Piccoli <gpiccoli@linux.vnet.ibm.com> Signed-off-by: Samuel Mendoza-Jonas <sam@mendozajonas.com>
-rwxr-xr-xutils/pb-sos10
1 files changed, 7 insertions, 3 deletions
diff --git a/utils/pb-sos b/utils/pb-sos
index 3fa8e89..e3e8f6b 100755
--- a/utils/pb-sos
+++ b/utils/pb-sos
@@ -2,7 +2,7 @@
diagdir="diag"
tarfile="pb-sos.tar"
-tarflags=""
+tarflags="-cf"
corefile="/core"
verbose=0
@@ -28,7 +28,7 @@ fi
while [ $# -gt 0 ]
do
case "$1" in
- -v) verbose=1; tarflags="$tarflags --verbose";;
+ -v) verbose=1; tarflags="--verbose $tarflags";;
-f) tarfile="$2"; shift;;
-d) desthost="$2"; shift;;
--) shift; break;;
@@ -69,7 +69,11 @@ cat /sys/firmware/opal/msglog > /$diagdir/msglog
log "Compressing..."
cd /
-tar $tarflags -cf $tarfile $diagdir
+
+tar $tarflags $tarfile $diagdir
+gzip < $tarfile > $tarfile.gz
+rm -f $tarfile
+tarfile="$tarfile.gz"
echo "Complete, tarfile location $tarfile"
OpenPOWER on IntegriCloud