From 4d4042d1021ef892c65726504d2600b1e40f39d6 Mon Sep 17 00:00:00 2001 From: Ross Burton Date: Tue, 15 May 2018 23:32:10 -0700 Subject: python2: Fix build with gcc8 Signed-off-by: Ross Burton Signed-off-by: Khem Raj Change-Id: Iddcb02c07c457cb27d6e0f69b7bbf6c4a14e61d3 [patch from openembedded-core mailing list] Signed-off-by: Joel Stanley --- .../python/python-native_2.7.14.bb | 1 + .../python/python/fix-gc-alignment.patch | 43 ++++++++++++++++++++++ .../meta/recipes-devtools/python/python_2.7.14.bb | 1 + 3 files changed, 45 insertions(+) create mode 100644 import-layers/yocto-poky/meta/recipes-devtools/python/python/fix-gc-alignment.patch diff --git a/import-layers/yocto-poky/meta/recipes-devtools/python/python-native_2.7.14.bb b/import-layers/yocto-poky/meta/recipes-devtools/python/python-native_2.7.14.bb index 7c491fa3e..b822583c5 100644 --- a/import-layers/yocto-poky/meta/recipes-devtools/python/python-native_2.7.14.bb +++ b/import-layers/yocto-poky/meta/recipes-devtools/python/python-native_2.7.14.bb @@ -16,6 +16,7 @@ SRC_URI += "\ file://builddir.patch \ file://parallel-makeinst-create-bindir.patch \ file://revert_use_of_sysconfigdata.patch \ + file://fix-gc-alignment.patch \ " S = "${WORKDIR}/Python-${PV}" diff --git a/import-layers/yocto-poky/meta/recipes-devtools/python/python/fix-gc-alignment.patch b/import-layers/yocto-poky/meta/recipes-devtools/python/python/fix-gc-alignment.patch new file mode 100644 index 000000000..b63cd0874 --- /dev/null +++ b/import-layers/yocto-poky/meta/recipes-devtools/python/python/fix-gc-alignment.patch @@ -0,0 +1,43 @@ +Upstream-Status: Submitted +Signed-off-by: Ross Burton + +Fix for over-aligned GC info +Patch by Florian Weimer + +See: https://bugzilla.redhat.com/show_bug.cgi?id=1540316 +Upstream discussion: https://mail.python.org/pipermail/python-dev/2018-January/152000.html + +diff --git a/Include/objimpl.h b/Include/objimpl.h +index 55e83eced6..aa906144dc 100644 +--- a/Include/objimpl.h ++++ b/Include/objimpl.h +@@ -248,6 +248,18 @@ PyAPI_FUNC(PyVarObject *) _PyObject_GC_Resize(PyVarObject *, Py_ssize_t); + /* for source compatibility with 2.2 */ + #define _PyObject_GC_Del PyObject_GC_Del + ++/* Former over-aligned definition of PyGC_Head, used to compute the ++ size of the padding for the new version below. */ ++union _gc_head; ++union _gc_head_old { ++ struct { ++ union _gc_head *gc_next; ++ union _gc_head *gc_prev; ++ Py_ssize_t gc_refs; ++ } gc; ++ long double dummy; ++}; ++ + /* GC information is stored BEFORE the object structure. */ + typedef union _gc_head { + struct { +@@ -255,7 +267,8 @@ typedef union _gc_head { + union _gc_head *gc_prev; + Py_ssize_t gc_refs; + } gc; +- long double dummy; /* force worst-case alignment */ ++ double dummy; /* force worst-case alignment */ ++ char dummy_padding[sizeof(union _gc_head_old)]; + } PyGC_Head; + + extern PyGC_Head *_PyGC_generation0; + \ No newline at end of file diff --git a/import-layers/yocto-poky/meta/recipes-devtools/python/python_2.7.14.bb b/import-layers/yocto-poky/meta/recipes-devtools/python/python_2.7.14.bb index 0a09926df..41a8609b1 100644 --- a/import-layers/yocto-poky/meta/recipes-devtools/python/python_2.7.14.bb +++ b/import-layers/yocto-poky/meta/recipes-devtools/python/python_2.7.14.bb @@ -30,6 +30,7 @@ SRC_URI += "\ file://add-CROSSPYTHONPATH-for-PYTHON_FOR_BUILD.patch \ file://pass-missing-libraries-to-Extension-for-mul.patch \ file://support_SOURCE_DATE_EPOCH_in_py_compile_2.7.patch \ + file://fix-gc-alignment.patch \ " S = "${WORKDIR}/Python-${PV}" -- cgit v1.2.1