diff options
| author | Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com> | 2017-07-19 01:03:13 -0500 |
|---|---|---|
| committer | Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com> | 2017-07-24 12:24:22 -0500 |
| commit | 3fb3920d7587fc82f28a51a96fbbf7ff81f97415 (patch) | |
| tree | 295605e966b3d976f7c1b09700e5200ac7d03092 /meta-phosphor/common/recipes-phosphor/leds | |
| parent | 25065d162ecdda17519a773dedf35ae28aa2bdc8 (diff) | |
| download | talos-openbmc-3fb3920d7587fc82f28a51a96fbbf7ff81f97415.tar.gz talos-openbmc-3fb3920d7587fc82f28a51a96fbbf7ff81f97415.zip | |
Fix a bug in driving LED during PowerOn and PowerOff
As part of PowerOn, group 'power_on' gets asserted via
a service file that is associated with PowerOn and that
results in driving corresponding physical LEDs.
This works fine for a single PowerOn and does not work if
there is a PowerOff followed by a PowerOn.
Service file had RemainAfterExit set and did not have a stop
condition. This commit puts a Conflicts relationship with
appropriate stop service file and vice versa.
Fixes openbmc/openbmc#1918
Change-Id: Ie0e6b554b3ab7beacd3ad15a0ff76e4d6481f648
Signed-off-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com>
Diffstat (limited to 'meta-phosphor/common/recipes-phosphor/leds')
2 files changed, 2 insertions, 0 deletions
diff --git a/meta-phosphor/common/recipes-phosphor/leds/phosphor-led-manager/obmc-led-group-start@.service b/meta-phosphor/common/recipes-phosphor/leds/phosphor-led-manager/obmc-led-group-start@.service index 7c0207c0d..36a443025 100644 --- a/meta-phosphor/common/recipes-phosphor/leds/phosphor-led-manager/obmc-led-group-start@.service +++ b/meta-phosphor/common/recipes-phosphor/leds/phosphor-led-manager/obmc-led-group-start@.service @@ -2,6 +2,7 @@ Description=Assert %i LED Wants=mapper-wait@-xyz-openbmc_project-led-groups-%i.service After=mapper-wait@-xyz-openbmc_project-led-groups-%i.service +Conflicts=obmc-led-group-stop@%i.service [Service] Type=oneshot diff --git a/meta-phosphor/common/recipes-phosphor/leds/phosphor-led-manager/obmc-led-group-stop@.service b/meta-phosphor/common/recipes-phosphor/leds/phosphor-led-manager/obmc-led-group-stop@.service index 4ddf0f8e2..e7799f34d 100644 --- a/meta-phosphor/common/recipes-phosphor/leds/phosphor-led-manager/obmc-led-group-stop@.service +++ b/meta-phosphor/common/recipes-phosphor/leds/phosphor-led-manager/obmc-led-group-stop@.service @@ -2,6 +2,7 @@ Description=Assert %i LED Wants=mapper-wait@-xyz-openbmc_project-led-groups-%i.service After=mapper-wait@-xyz-openbmc_project-led-groups-%i.service +Conflicts=obmc-led-group-start@%i.service [Service] Type=oneshot |
