summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMilton D. Miller II <miltonm@us.ibm.com>2016-02-28 17:08:50 -0600
committerMilton D. Miller II <miltonm@us.ibm.com>2016-03-02 20:01:22 -0600
commit576ea812a59f95fc41d40fceb721c121d0dd754d (patch)
tree33495ee39f03292844bfa79b237c407b5a34791a
parent5f60baefcb0fdeac76e03dcb13b171c50f74d7a1 (diff)
downloadtalos-openbmc-576ea812a59f95fc41d40fceb721c121d0dd754d.tar.gz
talos-openbmc-576ea812a59f95fc41d40fceb721c121d0dd754d.zip
shutdown: Conditionally unmount proc
The intention was to test the flag variable set when proc was mounted earlier in the script, not the constant string containing the name of the variable. The unnecessary unmount is not noticeable when a normal shutdown or reboot is being performed while executing after systemd, but results in a less usable environment when invoked manually. Signed-off-by: Milton Miller <miltonm@us.ibm.com>
-rw-r--r--meta-phosphor/common/recipes-phosphor/obmc-phosphor-initfs/files/obmc-shutdown.sh2
1 files changed, 1 insertions, 1 deletions
diff --git a/meta-phosphor/common/recipes-phosphor/obmc-phosphor-initfs/files/obmc-shutdown.sh b/meta-phosphor/common/recipes-phosphor/obmc-phosphor-initfs/files/obmc-shutdown.sh
index fc359c5be..216e7e403 100644
--- a/meta-phosphor/common/recipes-phosphor/obmc-phosphor-initfs/files/obmc-shutdown.sh
+++ b/meta-phosphor/common/recipes-phosphor/obmc-phosphor-initfs/files/obmc-shutdown.sh
@@ -45,7 +45,7 @@ fi
echo Remaining mounts:
cat /proc/mounts
-test "umount_proc" && umount /proc && rmdir /proc
+test "$umount_proc" && umount /proc && rmdir /proc
# ioctl(TIOC_DRAIN) to drain tty messages to console
test -t 1 && stty cooked 0<&1
OpenPOWER on IntegriCloud