From f3db6e82034a6ea89191fdcc6b9a984dc0d5d533 Mon Sep 17 00:00:00 2001 From: David Brownell Date: Sat, 5 Jan 2008 13:21:43 -0800 Subject: USB: at91_udc uses generic GPIO calls; minor cleanup Various small at91_udc cleanups: - Use generic GPIO calls, not older platform-specific ones - Use gpio_request()/gpio_free() - Use VERBOSE_DEBUG convention, not older VERBOSE - Fix sparse complaint about parameter type (changed to gfp_t) - Add missing newline to some rarely-seen debug messages - Fix some old cleanup bugs on probe() fault paths Also add a mechanism whereby rm9200 gpios can drive the D+ pullup through an inverting transistor, based on a patch from Steve Birtles. Most UDC drivers supporting a GPIO based pullup should probably have such an option, but testing it requries such a board in hand! Signed-off-by: David Brownell Cc: Steve Birtles Signed-off-by: Greg Kroah-Hartman --- drivers/usb/gadget/at91_udc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'drivers/usb/gadget/at91_udc.h') diff --git a/drivers/usb/gadget/at91_udc.h b/drivers/usb/gadget/at91_udc.h index f3095a90a0ee..a973f2a50fb9 100644 --- a/drivers/usb/gadget/at91_udc.h +++ b/drivers/usb/gadget/at91_udc.h @@ -158,7 +158,7 @@ struct at91_request { /*-------------------------------------------------------------------------*/ -#ifdef VERBOSE +#ifdef VERBOSE_DEBUG # define VDBG DBG #else # define VDBG(stuff...) do{}while(0) -- cgit v1.2.1