diff options
author | Samuel Mendoza-Jonas <sam@mendozajonas.com> | 2016-07-13 11:15:41 +1000 |
---|---|---|
committer | Joel Stanley <joel@jms.id.au> | 2017-07-18 14:53:29 +0930 |
commit | 5a59ec59cf2151206b91bdb7cbd61a3af8bd801c (patch) | |
tree | e765087634d4d817d96404aaf81488bbc82ef5a1 /net/lapb/lapb_in.c | |
parent | fb088cd934551856cd6a542b7bfd24b99466f366 (diff) | |
download | talos-op-linux-5a59ec59cf2151206b91bdb7cbd61a3af8bd801c.tar.gz talos-op-linux-5a59ec59cf2151206b91bdb7cbd61a3af8bd801c.zip |
tty/hvc: Use IRQF_SHARED for OPAL hvc consoles
Commit 2def86a7200c
("hvc: Convert to using interrupts instead of opal events")
enabled the use of interrupts in the hvc_driver for OPAL platforms.
However on machines with more than one hvc console, any console after
the first will fail to register an interrupt handler in
notifier_add_irq() since all consoles share the same IRQ number but do
not set the IRQF_SHARED flag:
[ 51.179907] genirq: Flags mismatch irq 31. 00000000 (hvc_console) vs.
00000000 (hvc_console)
[ 51.180010] hvc_open: request_irq failed with rc -16.
This error propagates up to hvc_open() and the console is closed, but
OPAL will still generate interrupts that are not handled, leading to
rcu_sched stall warnings.
Set IRQF_SHARED when calling request_irq, allowing additional consoles
to start properly. This is only set for consoles handled by
hvc_opal_probe(), leaving other types unaffected.
Signed-off-by: Samuel Mendoza-Jonas <sam@mendozajonas.com>
Cc: <stable@vger.kernel.org> # 4.1.x-
Signed-off-by: Joel Stanley <joel@jms.id.au>
Diffstat (limited to 'net/lapb/lapb_in.c')
0 files changed, 0 insertions, 0 deletions