diff options
| author | Steven Rostedt (Red Hat) <rostedt@goodmis.org> | 2014-06-05 20:35:30 -0400 |
|---|---|---|
| committer | Steven Rostedt <rostedt@goodmis.org> | 2014-06-05 20:35:30 -0400 |
| commit | 72e2fe38eac2dbf258d4295d75f78b123dd5b823 (patch) | |
| tree | 3966b0bc0dcb2d38837abdcd96d0a652354dd8b3 /kernel/trace/trace_benchmark.c | |
| parent | 939c7a4f04fcd2162109744e8bf88194948a6e65 (diff) | |
| download | talos-op-linux-72e2fe38eac2dbf258d4295d75f78b123dd5b823.tar.gz talos-op-linux-72e2fe38eac2dbf258d4295d75f78b123dd5b823.zip | |
tracing: Convert stddev into u64 in tracepoint benchmark
I've been told that do_div() expects an unsigned 64 bit number, and
is undefined if a signed is used. This gave a warning on the MIPS
build. I'm not sure if a signed 64 bit dividend is really an issue
or not, but the calculation this is used for is standard deviation,
and that isn't going to be negative. We can just convert it to
unsigned and be safe.
Reported-by: David Daney <ddaney.cavm@gmail.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Diffstat (limited to 'kernel/trace/trace_benchmark.c')
| -rw-r--r-- | kernel/trace/trace_benchmark.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/trace/trace_benchmark.c b/kernel/trace/trace_benchmark.c index a10adc7095cd..8bd3365a65b2 100644 --- a/kernel/trace/trace_benchmark.c +++ b/kernel/trace/trace_benchmark.c @@ -33,7 +33,7 @@ static void trace_do_benchmark(void) u64 start; u64 stop; u64 delta; - s64 stddev; + u64 stddev; u64 seed; u64 last_seed; unsigned int avg; |
