diff options
| author | Nicholas Bellinger <nab@linux-iscsi.org> | 2016-10-16 00:27:42 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-10-28 03:45:31 -0400 |
| commit | 7979d3c66d58e8926888eae2f2dde44a7a135a14 (patch) | |
| tree | 0120f493e7c74b76a3c32e004d651f21911411e4 /kernel/debug/debug_core.c | |
| parent | c24cc97368adc7bc708188f0e5652447b61117c5 (diff) | |
| download | talos-op-linux-7979d3c66d58e8926888eae2f2dde44a7a135a14.tar.gz talos-op-linux-7979d3c66d58e8926888eae2f2dde44a7a135a14.zip | |
Revert "target: Fix residual overflow handling in target_complete_cmd_with_length"
commit 61f36166c245e563c7a2b624f4c78c5ce0f680d6 upstream.
This reverts commit c1ccbfe0311e2380a6d2dcb0714b36904f5d586f.
Reverting this patch, as it incorrectly assumes the additional length
for INQUIRY in target_complete_cmd_with_length() is SCSI allocation
length, which breaks existing user-space code when SCSI allocation
length is smaller than additional length.
root@scsi-mq:~# sg_inq --len=4 -vvvv /dev/sdb
found bsg_major=253
open /dev/sdb with flags=0x800
inquiry cdb: 12 00 00 00 04 00
duration=0 ms
inquiry: pass-through requested 4 bytes (data-in) but got -28 bytes
inquiry: pass-through can't get negative bytes, say it got none
inquiry: got too few bytes (0)
INQUIRY resid (32) should never exceed requested len=4
inquiry: failed requesting 4 byte response: Malformed response to
SCSI command [resid=32]
AFAICT the original change was not to address a specific host issue,
so go ahead and revert to original logic for now.
Cc: Douglas Gilbert <dgilbert@interlog.com>
Cc: Martin K. Petersen <martin.petersen@oracle.com>
Cc: Sumit Rai <sumitrai96@gmail.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'kernel/debug/debug_core.c')
0 files changed, 0 insertions, 0 deletions
