diff options
author | Nicholas Bellinger <nab@linux-iscsi.org> | 2014-03-30 15:50:03 -0700 |
---|---|---|
committer | Nicholas Bellinger <nab@linux-iscsi.org> | 2014-04-07 01:48:51 -0700 |
commit | 03e7848a64ed535a30f5d7fc6dede2d5a6a2534b (patch) | |
tree | 30a0f445d7725ac41ed9fdfc389ea03f171322ed /include/net/neighbour.h | |
parent | 131e6abc674edb9f9a59090bb35bf6650569b7e7 (diff) | |
download | talos-op-linux-03e7848a64ed535a30f5d7fc6dede2d5a6a2534b.tar.gz talos-op-linux-03e7848a64ed535a30f5d7fc6dede2d5a6a2534b.zip |
iser-target: Add missing se_cmd put for WRITE_PENDING in tx_comp_err
This patch fixes a bug where outstanding RDMA_READs with WRITE_PENDING
status require an extra target_put_sess_cmd() in isert_put_cmd() code
when called from isert_cq_tx_comp_err() + isert_cq_drain_comp_llist()
context during session shutdown.
The extra kref PUT is required so that transport_generic_free_cmd()
invokes the last target_put_sess_cmd() -> target_release_cmd_kref(),
which will complete(&se_cmd->cmd_wait_comp) the outstanding se_cmd
descriptor with WRITE_PENDING status, and awake the completion in
target_wait_for_sess_cmds() to invoke TFO->release_cmd().
The bug was manifesting itself in target_wait_for_sess_cmds() where
a se_cmd descriptor with WRITE_PENDING status would end up sleeping
indefinately.
Acked-by: Sagi Grimberg <sagig@mellanox.com>
Cc: Or Gerlitz <ogerlitz@mellanox.com>
Cc: <stable@vger.kernel.org> #3.10+
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'include/net/neighbour.h')
0 files changed, 0 insertions, 0 deletions