diff options
author | Stefan Richter <stefanr@s5r6.in-berlin.de> | 2011-07-06 15:54:48 -0300 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2011-07-27 17:53:38 -0300 |
commit | 686a9488cd23cce1fa8a6cddde0e7668ae2e74b4 (patch) | |
tree | 68690c3a2dc4204ed9a139e7ce2821d7bc524c3f /drivers/media/video | |
parent | 7a286cc1889f14c5c8dbf866718edde100527d8c (diff) | |
download | talos-op-linux-686a9488cd23cce1fa8a6cddde0e7668ae2e74b4.tar.gz talos-op-linux-686a9488cd23cce1fa8a6cddde0e7668ae2e74b4.zip |
[media] firedtv: change some -EFAULT returns to more fitting error codes
Mauro Carvalho Chehab wrote:
> I'm validating if all drivers are behaving equally with respect to the
> error codes returned to userspace, and double-checking with the API.
>
> On almost all places, -EFAULT code is used only to indicate when
> copy_from_user/copy_to_user fails. However, firedtv uses a lot of
> -EFAULT, where it seems to me that other error codes should be used
> instead (like -EIO for bus transfer errors and -EINVAL/-ERANGE for
> invalid/out of range parameters).
This concerns only the CI (CAM) related code of firedtv of which I know
little. Let's just pass through the error returns of lower level I/O
code where applicable, and -EACCES (permission denied) when a seemingly
valid but negative FCP response or an unknown-to-firedtv CA message is
received.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Henrik Kurelid <henrik@kurelid.se>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/video')
0 files changed, 0 insertions, 0 deletions