diff options
| author | Namhyung Kim <namhyung@gmail.com> | 2011-03-24 11:42:30 +0900 |
|---|---|---|
| committer | Ingo Molnar <mingo@elte.hu> | 2011-03-24 08:36:10 +0100 |
| commit | 71f9e59800e5ad4e6b683348424c9fe54306cd43 (patch) | |
| tree | 0ddf852d8933208e1fd781f1dbf047eb0cf737f7 /arch/x86/kernel | |
| parent | 0f77a8d378254f27df4a114a5da67223af1fe93f (diff) | |
| download | talos-op-linux-71f9e59800e5ad4e6b683348424c9fe54306cd43.tar.gz talos-op-linux-71f9e59800e5ad4e6b683348424c9fe54306cd43.zip | |
x86, dumpstack: Use %pB format specifier for stack trace
Improve noreturn function entries in call traces:
Before:
Call Trace:
[<ffffffff812a8502>] panic+0x8c/0x18d
[<ffffffffa000012a>] deep01+0x0/0x38 [test_panic] <--- bad
[<ffffffff81104666>] proc_file_write+0x73/0x8d
[<ffffffff811000b3>] proc_reg_write+0x8d/0xac
[<ffffffff810c7d32>] vfs_write+0xa1/0xc5
[<ffffffff810c7e0f>] sys_write+0x45/0x6c
[<ffffffff8f02943b>] system_call_fastpath+0x16/0x1b
After:
Call Trace:
[<ffffffff812bce69>] panic+0x8c/0x18d
[<ffffffffa000012a>] panic_write+0x20/0x20 [test_panic] <--- good
[<ffffffff81115fab>] proc_file_write+0x73/0x8d
[<ffffffff81111a5f>] proc_reg_write+0x8d/0xac
[<ffffffff810d90ee>] vfs_write+0xa1/0xc5
[<ffffffff810d91cb>] sys_write+0x45/0x6c
[<ffffffff812c07fb>] system_call_fastpath+0x16/0x1b
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
LKML-Reference: <1300934550-21394-2-git-send-email-namhyung@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'arch/x86/kernel')
| -rw-r--r-- | arch/x86/kernel/dumpstack.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c index 999e2793590b..24d0479025f9 100644 --- a/arch/x86/kernel/dumpstack.c +++ b/arch/x86/kernel/dumpstack.c @@ -27,7 +27,7 @@ static int die_counter; void printk_address(unsigned long address, int reliable) { - printk(" [<%p>] %s%pS\n", (void *) address, + printk(" [<%p>] %s%pB\n", (void *) address, reliable ? "" : "? ", (void *) address); } |
