diff options
author | Benoît Thébaudeau <benoit.thebaudeau@advansee.com> | 2012-06-12 19:46:43 +0200 |
---|---|---|
committer | Sascha Hauer <s.hauer@pengutronix.de> | 2012-06-13 09:03:24 +0200 |
commit | 33a264ddcded2120fc0baa7afe4bcc5b4df3c416 (patch) | |
tree | dc04c6e89f00a27b4dd213cd322b034b4d96462f /arch/arm/mach-imx/mach-mx51_babbage.c | |
parent | cfaf025112d3856637ff34a767ef785ef5cf2ca9 (diff) | |
download | talos-op-linux-33a264ddcded2120fc0baa7afe4bcc5b4df3c416.tar.gz talos-op-linux-33a264ddcded2120fc0baa7afe4bcc5b4df3c416.zip |
ARM: imx: cleanup otg_mode
Cleanup the code for the otg_mode command line param:
* Use the bool type as it applies here.
* Qualify otg_mode_host with __initdata since this variable is only used in this
context.
* The __setup functions are not supposed to return a status code, but a boolean
indicating whether the param has been handled. See obsolete_checksetup() in
init/main.c.
Signed-off-by: Benoît Thébaudeau <benoit.thebaudeau@advansee.com>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Diffstat (limited to 'arch/arm/mach-imx/mach-mx51_babbage.c')
-rw-r--r-- | arch/arm/mach-imx/mach-mx51_babbage.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/arch/arm/mach-imx/mach-mx51_babbage.c b/arch/arm/mach-imx/mach-mx51_babbage.c index dde397014d4b..3ca6902dfc34 100644 --- a/arch/arm/mach-imx/mach-mx51_babbage.c +++ b/arch/arm/mach-imx/mach-mx51_babbage.c @@ -307,18 +307,18 @@ static const struct mxc_usbh_platform_data usbh1_config __initconst = { .portsc = MXC_EHCI_MODE_ULPI, }; -static int otg_mode_host; +static bool otg_mode_host __initdata; static int __init babbage_otg_mode(char *options) { if (!strcmp(options, "host")) - otg_mode_host = 1; + otg_mode_host = true; else if (!strcmp(options, "device")) - otg_mode_host = 0; + otg_mode_host = false; else pr_info("otg_mode neither \"host\" nor \"device\". " "Defaulting to device\n"); - return 0; + return 1; } __setup("otg_mode=", babbage_otg_mode); |