summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBenny Halevy <bhalevy@tonian.com>2011-10-19 19:13:06 -0700
committerJ. Bruce Fields <bfields@redhat.com>2011-10-24 04:24:28 -0400
commitfc0c3dd13bac0675cdedc4e0d0641aa8a22e82de (patch)
treee5762e78be340718fc90aa1fc8660124293460e3
parent5423732a71577f7860c56a4eea2c34ff162ddd73 (diff)
downloadtalos-op-linux-fc0c3dd13bac0675cdedc4e0d0641aa8a22e82de.tar.gz
talos-op-linux-fc0c3dd13bac0675cdedc4e0d0641aa8a22e82de.zip
nfsd4: seq->status_flags may be used unitialized
Reported-by: Gopala Suryanarayana <gsuryanarayana@vmware.com> Signed-off-by: Benny Halevy <bhalevy@tonian.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
-rw-r--r--fs/nfsd/nfs4state.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index b51ad43b7ea1..1527aaffb000 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -1947,11 +1947,13 @@ out:
atomic_inc(&clp->cl_refcount);
switch (clp->cl_cb_state) {
case NFSD4_CB_DOWN:
- seq->status_flags |= SEQ4_STATUS_CB_PATH_DOWN;
+ seq->status_flags = SEQ4_STATUS_CB_PATH_DOWN;
break;
case NFSD4_CB_FAULT:
- seq->status_flags |= SEQ4_STATUS_BACKCHANNEL_FAULT;
+ seq->status_flags = SEQ4_STATUS_BACKCHANNEL_FAULT;
break;
+ default:
+ seq->status_flags = 0;
}
}
kfree(conn);
OpenPOWER on IntegriCloud